This is V2 to support ima/evm uuid in ubifs. - the previously used memcopy is now replaced by a helper function as suggested by Andy jb
This is V2 to support ima/evm uuid in ubifs. - the previously used memcopy is now replaced by a helper function as suggested by Andy jb ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
From: Steffen Trumtrar <s.trumtrar@pengutronix.de> This is required to provide uuid based integrity functionality for: ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option). Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de> Co-developed-by: Juergen Borleis <jbe@pengutronix.de> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- fs/ubifs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 138b9426c6c1..a8383ca39a47 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) goto out_umount; } + import_uuid(&sb->s_uuid, c->uuid); + mutex_unlock(&c->umount_mutex); return 0; -- 2.20.1
From: Steffen Trumtrar <s.trumtrar@pengutronix.de> This is required to provide uuid based integrity functionality for: ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option). Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de> Co-developed-by: Juergen Borleis <jbe@pengutronix.de> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- fs/ubifs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 138b9426c6c1..a8383ca39a47 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) goto out_umount; } + import_uuid(&sb->s_uuid, c->uuid); + mutex_unlock(&c->umount_mutex); return 0; -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote: > > From: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > This is required to provide uuid based integrity functionality for: > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option). Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> One issue below has to be addressed nevertheless. > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de> > Co-developed-by: Juergen Borleis <jbe@pengutronix.de> According to the documentation [1] above has two issues: - all Co-developed-by *must* be accompanied with corresponding SoBs - commiter must provide his SoB (but it will be implied by the previous requirement in this case) [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > fs/ubifs/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 138b9426c6c1..a8383ca39a47 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) > goto out_umount; > } > > + import_uuid(&sb->s_uuid, c->uuid); > + > mutex_unlock(&c->umount_mutex); > return 0; > > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko
On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote: > > From: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > This is required to provide uuid based integrity functionality for: > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option). Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> One issue below has to be addressed nevertheless. > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de> > Co-developed-by: Juergen Borleis <jbe@pengutronix.de> According to the documentation [1] above has two issues: - all Co-developed-by *must* be accompanied with corresponding SoBs - commiter must provide his SoB (but it will be implied by the previous requirement in this case) [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > fs/ubifs/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 138b9426c6c1..a8383ca39a47 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) > goto out_umount; > } > > + import_uuid(&sb->s_uuid, c->uuid); > + > mutex_unlock(&c->umount_mutex); > return 0; > > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
+Cc: Stephen
Stephen, do you have a check in Linux Next to catch the problem that
Co-developed-by is not being accompanied by a corresponding SoB?
On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote:
> >
> > From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> >
> > This is required to provide uuid based integrity functionality for:
> > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> One issue below has to be addressed nevertheless.
>
> > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > Co-developed-by: Juergen Borleis <jbe@pengutronix.de>
>
> According to the documentation [1] above has two issues:
> - all Co-developed-by *must* be accompanied with corresponding SoBs
> - commiter must provide his SoB (but it will be implied by the
> previous requirement in this case)
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
>
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > fs/ubifs/super.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> > index 138b9426c6c1..a8383ca39a47 100644
> > --- a/fs/ubifs/super.c
> > +++ b/fs/ubifs/super.c
> > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
> > goto out_umount;
> > }
> >
> > + import_uuid(&sb->s_uuid, c->uuid);
> > +
> > mutex_unlock(&c->umount_mutex);
> > return 0;
> >
> > --
> > 2.20.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
+Cc: Stephen Stephen, do you have a check in Linux Next to catch the problem that Co-developed-by is not being accompanied by a corresponding SoB? On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote: > > > > From: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > > > This is required to provide uuid based integrity functionality for: > > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option). > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > One issue below has to be addressed nevertheless. > > > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de> > > Co-developed-by: Juergen Borleis <jbe@pengutronix.de> > > According to the documentation [1] above has two issues: > - all Co-developed-by *must* be accompanied with corresponding SoBs > - commiter must provide his SoB (but it will be implied by the > previous requirement in this case) > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > --- > > fs/ubifs/super.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > > index 138b9426c6c1..a8383ca39a47 100644 > > --- a/fs/ubifs/super.c > > +++ b/fs/ubifs/super.c > > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) > > goto out_umount; > > } > > > > + import_uuid(&sb->s_uuid, c->uuid); > > + > > mutex_unlock(&c->umount_mutex); > > return 0; > > > > -- > > 2.20.1 > > > > > -- > With Best Regards, > Andy Shevchenko -- With Best Regards, Andy Shevchenko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
[-- Attachment #1: Type: text/plain, Size: 342 bytes --] Hi Andy, On Tue, 16 Feb 2021 11:11:08 +0200 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > Stephen, do you have a check in Linux Next to catch the problem that > Co-developed-by is not being accompanied by a corresponding SoB? No, but I will see about adding one. Thanks fo rthe heads up. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #1.1: Type: text/plain, Size: 342 bytes --] Hi Andy, On Tue, 16 Feb 2021 11:11:08 +0200 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > Stephen, do you have a check in Linux Next to catch the problem that > Co-developed-by is not being accompanied by a corresponding SoB? No, but I will see about adding one. Thanks fo rthe heads up. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/