From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test
Date: Tue, 16 Feb 2021 16:38:06 -0500 [thread overview]
Message-ID: <20210216213806.GA10169@bill-the-cat> (raw)
In-Reply-To: <c0bad3e4e724683543fd03239d80a256@walle.cc>
On Tue, Feb 16, 2021 at 10:33:37PM +0100, Michael Walle wrote:
> Am 2021-02-16 22:21, schrieb Vladimir Oltean:
> > On Tue, Feb 16, 2021 at 04:13:41PM -0500, Tom Rini wrote:
> > > On Tue, Feb 16, 2021 at 11:02:25PM +0200, Vladimir Oltean wrote:
> > > > Hi Tom,
> > > >
> > > > On Tue, Feb 16, 2021 at 01:14:57PM -0500, Tom Rini wrote:
> > > > > This test does not pass for me. This can be seen at:
> > > > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660
> > > > >
> > > > > Note that I'm still reviewing the rest of the series right now.
> > > >
> > > > You're right, thanks for letting me know.
> > > > I've fixed this in my tree [ by adding two more patches :-/ ], let me
> > > > know if you have any other feedback, otherwise I'm going to resend soon.
> > >
> > > I'm about to push the rest of the series, so you can rebase on master
> > > shortly, thanks! Or should I hold off as this exposed problems in the
> > > rest of your series?
> >
> > Sorry, I missed your reply earlier. I just sent out a new version which
> > should be sandbox-clean and which also makes the fixed PHY driver
> > compatible with live OF, since that's what the problem was, essentially.
>
> If this series is merged, I'd just send a follow up for the kontron sl28
> board device tree, which also uses DSA. Originally, this it wasn't
> possible to include the patch in this series, because there was still
> the base device tree for this board variant pending in u-boot.
>
> So if possible, I'd welcome it if it can be merged after this series.
OK, so I guess there's a small amount of follow-up to finish enabling it
as I see, today with v4:
kontron_sl28 : all +9467 bss +2560 data +568 rodata +675 spl/u-boot-spl:all +18 spl/u-boot-spl:rodata +18 text +5664
when building and it's on just a few layerscape platforms so I assumed
it was enabling everything.
And, I'm inclined to go with reposting just a follow-up that fixes /
enables sandbox and livetree as I would like to both:
- Not delay the whole thing further
- Not merge other changes immediately after they're posted[*]
--
Tom
[*]: Yes, I did this literally yesterday, but for a security series I
had seen prior, so a special case I don't like either, but... anyhow.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210216/aeb97ea2/attachment.sig>
next prev parent reply other threads:[~2021-02-16 21:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 12:23 [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver Vladimir Oltean
2021-01-25 12:23 ` [PATCH v4 1/7] net: phy: fixed: support speeds of 2500 and 10000 Vladimir Oltean
2021-01-27 8:04 ` Claudiu Manoil
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 2/7] net: phy: introduce fixed_phy_create for DSA CPU ports Vladimir Oltean
2021-01-27 8:05 ` Claudiu Manoil
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 3/7] net: Introduce DSA class for Ethernet switches Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test Vladimir Oltean
2021-02-16 18:14 ` Tom Rini
2021-02-16 21:02 ` Vladimir Oltean
2021-02-16 21:13 ` Tom Rini
2021-02-16 21:21 ` Vladimir Oltean
2021-02-16 21:33 ` Michael Walle
2021-02-16 21:38 ` Tom Rini [this message]
2021-02-16 21:53 ` Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-02-16 21:58 ` Michael Walle
2021-02-16 22:15 ` Michael Walle
2021-02-16 22:23 ` Vladimir Oltean
2021-01-25 12:23 ` [PATCH v4 5/7] drivers: net: Add Felix DSA switch driver Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 6/7] arm: dts: ls1028a: Add Ethernet switch node and dependencies Vladimir Oltean
2021-01-25 12:33 ` Michael Walle
2021-02-16 21:56 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 7/7] configs: ls1028a: Enable the Ethernet switch driver in defconfig Vladimir Oltean
2021-02-16 21:56 ` Tom Rini
2021-01-25 13:02 ` [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver Michael Walle
2021-01-25 13:04 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216213806.GA10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.