All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/scripts/size-stats: increase number of files that can be linked to a source
Date: Tue, 16 Feb 2021 22:10:37 +0100	[thread overview]
Message-ID: <20210216221037.36b7e48c@windsurf.home> (raw)
In-Reply-To: <CAAXf6LXXEV3PZ1rQ58nJhR7g-Jgra71wtkWmbo8t9ihAruum9Q@mail.gmail.com>

On Tue, 16 Feb 2021 15:06:39 +0100
Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote:

> Please extend your commit message with more information: what is the
> problem you're fixing, and how are you fixing it.
> Right now, we can only guess what it is doing based on the code.
> 
> It looks like the change is extending the size information to
> rootfs-overlays, while today only real packages are considered.
> But if that is correct, then the title "increase number of files that
> can be linked to a source" is confusing to me.

The change is not just about the rootfs overlay, but also about taking
into account .pyc files compiled from .py files:

+            # account for python file compilation
+            if fpath.endswith('.py'):
+                add_file(filesdict, fpath + 'c', fullpath + 'c', pkg)

This should at least be separated in another patch. I'm not a huge fan
of this approach, but I don't really have a good suggestion. Ideally,
we should byte-compile each package independently, so that it's part of
the install step of the package. But that would be vastly less
efficient than just byte-compiling everything in one go at the end of
the build, like we're doing.

Daniel: could you rework your patch a bit, splitting it into several
patches, with a slightly improved commit log ? I think it makes a lot
of sense to have these improvements to size-stats.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-02-16 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 11:05 [Buildroot] [PATCH 1/1] support/scripts/size-stats: increase number of files that can be linked to a source Daniel Crowe
2021-02-16 14:06 ` Thomas De Schampheleire
2021-02-16 21:10   ` Thomas Petazzoni [this message]
2021-02-16 22:57     ` Daniel Crowe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216221037.36b7e48c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.