From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31D4C433DB for ; Tue, 16 Feb 2021 23:13:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8020364E65 for ; Tue, 16 Feb 2021 23:13:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8020364E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC9Ws-0001So-Fs for qemu-devel@archiver.kernel.org; Tue, 16 Feb 2021 18:13:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC9W1-0000hA-6M; Tue, 16 Feb 2021 18:12:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:42796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC9Vz-0007yE-Kp; Tue, 16 Feb 2021 18:12:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 92B4164E7A; Tue, 16 Feb 2021 23:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613517136; bh=POGCWEywOoXtGSSW6UtbE+UNePDYsvxtAghkQG/hedQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dbFAf/OUHfBBkCGq3O0+D2mktzZhKkOxbiNrMzEiLgMPyxPcHL/rsHOgEnjp5U4ZO b57mq3RtjMUumId3fXBEi9iji56lav/VXmw+qP9Eo1m98ZXdE6FwqZFyOpV7sGllvN YJPjWix1YiQUYDuu76VisSMzRi27GRYNQEL64Fm+rOnoulBBHF4oD4mUSzBQLIZ50k pyDHmwT376rHPqfFIN7COT9V6eUQlkFMdIKCesv8WZkkf8dtLHSeSxYkxyyMlYE/t1 pDiypWQt7ys8HYUe/C3j1dZxP8/ufW/NyiYRt2OFXdfE1KdOL+2ZY/zWNxN7hLntxS edwQd0JDVY0Ag== Date: Tue, 16 Feb 2021 15:12:13 -0800 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH RFC v3 09/12] hw/block/nvme: add verify command Message-ID: <20210216231213.GE2708768@dhcp-10-100-145-180.wdc.com> References: <20210214230240.301275-1-its@irrelevant.dk> <20210214230240.301275-10-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210214230240.301275-10-its@irrelevant.dk> Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Gollu Appalanaidu , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Feb 15, 2021 at 12:02:37AM +0100, Klaus Jensen wrote: > From: Gollu Appalanaidu > > See NVM Express 1.4, section 6.14 ("Verify Command"). > > Signed-off-by: Gollu Appalanaidu > [k.jensen: rebased, refactored for e2e] > Signed-off-by: Klaus Jensen Verify is a generic block command supported in other protocols beyond nvme. If we're going to support the command in nvme, I prefer the implementation had generic backing out of the qemu block API rather than emulate the entirety out of the nvme device.