All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Shaun Jackman <sjackman@gmail.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: elo - fix an error code in elo_connect()
Date: Wed, 17 Feb 2021 11:24:19 +0300	[thread overview]
Message-ID: <20210217082419.GK2222@kadam> (raw)
In-Reply-To: <YCydi5tfV/l0NGHw@google.com>

On Tue, Feb 16, 2021 at 08:37:31PM -0800, Dmitry Torokhov wrote:
> Hi Dan,
> 
> On Thu, Jan 28, 2021 at 12:35:51PM +0300, Dan Carpenter wrote:
> > If elo_setup_10() fails then this should return an error code instead
> > of success.
> 
> Thank you for the patch.
> 
> > 
> > Fixes: fae3006e4b42 ("Input: elo - add support for non-pressure-sensitive touchscreens")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/input/touchscreen/elo.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
> > index e0bacd34866a..4b2fb73da5e2 100644
> > --- a/drivers/input/touchscreen/elo.c
> > +++ b/drivers/input/touchscreen/elo.c
> > @@ -341,8 +341,10 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
> >  	switch (elo->id) {
> >  
> >  	case 0: /* 10-byte protocol */
> > -		if (elo_setup_10(elo))
> > +		if (elo_setup_10(elo)) {
> > +			err = -EINVAL;
> 
> Ideally we'd propagate error from elo_setup_10() and underlying code,
> but we are not ready for it, as most serio code simply uses -1 for
> errors. However I think that -EIO would suit better here. Please let me
> know if you disagree, otherwise I'll fix it up on my side.
> 

-EIO is fine.  Thanks!

regards,
dan carpenter


      reply	other threads:[~2021-02-17  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  9:35 [PATCH] Input: elo - fix an error code in elo_connect() Dan Carpenter
2021-01-28  9:35 ` Dan Carpenter
2021-02-17  4:37 ` Dmitry Torokhov
2021-02-17  8:24   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217082419.GK2222@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gustavoars@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=sjackman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.