From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18D5C433E0 for ; Wed, 17 Feb 2021 12:39:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 403A764E42 for ; Wed, 17 Feb 2021 12:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 403A764E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCM6o-0005mt-Sn for qemu-devel@archiver.kernel.org; Wed, 17 Feb 2021 07:39:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCM5V-0005NP-Da for qemu-devel@nongnu.org; Wed, 17 Feb 2021 07:37:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lCM5T-0005VS-5p for qemu-devel@nongnu.org; Wed, 17 Feb 2021 07:37:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613565465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJam4jX2YLcS5UIs+M/34JjdEp7cYluV/0Adss19Es0=; b=XmnigZdMM5/u6Mbs1ehL7RfITqkHfE+bWixQIADZqVYPnKDSFwtaL2rU72Ag1HVIWPbZqP J3QQYDWVRSj7LOyxtyu5pA0lONBsHPUVT4c3H0FG4nfJy85GwcEN8RTJKvofAqfniIQ4tP lmreZ6q1HuYDV0X6C+Svhxi/ZdHz0Vg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-miSaR6TRP66-vLgX8XHpNA-1; Wed, 17 Feb 2021 07:37:43 -0500 X-MC-Unique: miSaR6TRP66-vLgX8XHpNA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84397107ACED for ; Wed, 17 Feb 2021 12:37:42 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 575046F968; Wed, 17 Feb 2021 12:37:39 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9DF6A18000A2; Wed, 17 Feb 2021 13:37:37 +0100 (CET) Date: Wed, 17 Feb 2021 13:37:37 +0100 From: Gerd Hoffmann To: marcandre.lureau@redhat.com Subject: Re: [PATCH 1/2] spice: flush on GL update before notifying client Message-ID: <20210217123737.wvs3vtlr4f3j4ty4@sirius.home.kraxel.org> References: <20210216092056.2301293-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210216092056.2301293-1-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 16, 2021 at 01:20:55PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Since the introduction of spice/virgl support in commit > 474114b7 ("spice: add opengl/virgl/dmabuf support"), the drawing isn't > being flushed before notifying the client. This results in > outdated/sluggish drawing on client side, in particular when using the > Linux console. > + glFlush(); Nice catch. Older mesa versions must have been less picky on correct flushing, it used to work fine a while ago. Both patches queued up for UI. thanks, Gerd