From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B236DC433E0 for ; Wed, 17 Feb 2021 13:11:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1EFF64DFF for ; Wed, 17 Feb 2021 13:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1EFF64DFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCMcV-0002pC-LN for qemu-devel@archiver.kernel.org; Wed, 17 Feb 2021 08:11:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCMa5-00027I-P3 for qemu-devel@nongnu.org; Wed, 17 Feb 2021 08:09:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lCMa3-0006Si-EF for qemu-devel@nongnu.org; Wed, 17 Feb 2021 08:09:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613567362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wot+VZLx+lFv02YAKxdUTSRJ6j+aHYWDMyUP0jjKF5A=; b=V0ahElDI+pT+tVE9JNplUfDNXSG9KY+mVd40NPzAn/Kmr9+0OfqBxPZ1Y+yMm5v1RTnfSr 5hNq2/yFlmrNl2XVrD9RogEnZaszHz+2i4KwKgh4pD6JmVmIQFaZlNUsl+pcH6HuBoTorG 1EPXUCwBWQuaAN3e7hMankG3po+vtCw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-biBSvWIjMGKH3RoLe5xoMQ-1; Wed, 17 Feb 2021 08:09:20 -0500 X-MC-Unique: biBSvWIjMGKH3RoLe5xoMQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9449192D785; Wed, 17 Feb 2021 13:09:19 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74A471349A; Wed, 17 Feb 2021 13:09:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 60ED31800398; Wed, 17 Feb 2021 14:09:15 +0100 (CET) Date: Wed, 17 Feb 2021 14:09:15 +0100 From: Gerd Hoffmann To: Akihiko Odaki Subject: Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs Message-ID: <20210217130915.ihqdqxjqmbrzlvpv@sirius.home.kraxel.org> References: <20210212000540.28486-1-akihiko.odaki@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210212000540.28486-1-akihiko.odaki@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: > The detections of full screen APIs were wrong. A detection is coded as: > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] > but it should be: > [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)] > > The uses of full screen APIs were also incorrect, and if you fix the > detections, the full screen view stretches the video, changing the > aspect ratio, even if zooming is disabled. > > Remove the code as it does nothing good. So, it's broken right now (and probably for quite a while without anyone complaining). And the attempt to fix it didn't work out very well. Correct? Just dropping the code makes sense to me then. Any objections or better suggestions from the macos camp? If not I'll go queue it for the next UI pull request in a day or two. thanks, Gerd