From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E38C433E0 for ; Wed, 17 Feb 2021 17:23:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B02E364E2F for ; Wed, 17 Feb 2021 17:23:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B02E364E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 482756E0E8; Wed, 17 Feb 2021 17:23:04 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC9156E0E8 for ; Wed, 17 Feb 2021 17:23:02 +0000 (UTC) IronPort-SDR: XvnQxkJPkcbLtqy5f2E8rjjyOoLhsA7OkJSx75/RaYek/4IFKv6qDlf1E+XlmUTl8e5wszZsDW jeVRfkTQGErw== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="183386641" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="183386641" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:23:01 -0800 IronPort-SDR: M8M7MT8IlajpG1CN6V4N6Q90cg6b8O0MsWUxSjq0RsPu8oyBGte5puiqumOlulc73f2GGkRRdZ NzTpdaufAoWQ== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="385270333" Received: from dsdani-mobl1.amr.corp.intel.com (HELO ldmartin-desk1) ([10.209.4.37]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:23:01 -0800 Date: Wed, 17 Feb 2021 09:23:00 -0800 From: Lucas De Marchi To: Jani Nikula Message-ID: <20210217172300.6uuie7js4a4cpqvl@ldmartin-desk1> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH 04/12] drm/i915/bios: limit default outputs to ports A through F X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 17, 2021 at 07:03:34PM +0200, Jani Nikula wrote: >With the defaults limited to non-TypeC ports in commit 828ccb31cf41 >("drm/i915/icl: Add TypeC ports only if VBT is present"), this should be >a no-op, but clarifies the code and prepares for subsequent changes. > >Cc: Lucas De Marchi >Cc: Ville Syrj=E4l=E4 >Signed-off-by: Jani Nikula >--- > drivers/gpu/drm/i915/display/intel_bios.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i= 915/display/intel_bios.c >index e9cb15aa2f5a..b9d99324d66d 100644 >--- a/drivers/gpu/drm/i915/display/intel_bios.c >+++ b/drivers/gpu/drm/i915/display/intel_bios.c >@@ -2057,11 +2057,12 @@ static void > init_vbt_missing_defaults(struct drm_i915_private *i915) > { > enum port port; >+ int ports =3D PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F; I'd not spread the knowledge of what port uses tc phy like this. It's painful to maintain. Lucas De Marchi > > if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915)) > return; > >- for_each_port(port) { >+ for_each_port_masked(port, ports) { > struct ddi_vbt_port_info *info =3D > &i915->vbt.ddi_port_info[port]; > enum phy phy =3D intel_port_to_phy(i915, port); >-- = >2.20.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx