From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAA0C433E6 for ; Thu, 18 Feb 2021 07:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B48B64E15 for ; Thu, 18 Feb 2021 07:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbhBRH6d (ORCPT ); Thu, 18 Feb 2021 02:58:33 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:41897 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbhBRH4N (ORCPT ); Thu, 18 Feb 2021 02:56:13 -0500 Received: from uno.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0BE67200011; Thu, 18 Feb 2021 07:54:44 +0000 (UTC) Date: Thu, 18 Feb 2021 08:55:10 +0100 From: Jacopo Mondi To: Andrey Konovalov Cc: junak.pub@gmail.com, robert.foss@linaro.org, sakari.ailus@linux.intel.com, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] v4l: common: v4l2_get_link_freq: add printing a warning Message-ID: <20210218075510.dcqbpmft46bymmnd@uno.localdomain> References: <20210217221134.2606-1-andrey.konovalov@linaro.org> <20210217221134.2606-2-andrey.konovalov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210217221134.2606-2-andrey.konovalov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Andrey, On Thu, Feb 18, 2021 at 01:11:32AM +0300, Andrey Konovalov wrote: > Print a warning if V4L2_CID_LINK_FREQ control is not implemented. > > Signed-off-by: Andrey Konovalov > --- > drivers/media/v4l2-core/v4l2-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c > index 133d20e40f82..f1abdf2ab4ec 100644 > --- a/drivers/media/v4l2-core/v4l2-common.c > +++ b/drivers/media/v4l2-core/v4l2-common.c > @@ -461,6 +461,8 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, > > freq = qm.value; > } else { > + pr_warn("%s: V4L2_CID_LINK_FREQ not implemented\n", __func__); > + It's a shame we can't access a struct device * somehow :( Also, nitpicking (please bear with me here) it is absolutely correct that V4L2_CID_LINK_FREQ is not implemented, but I think the real deal here is that the link rate is estimanted from PIXEL_RATE and that might be wrong. What about (insipired from the error message in match_fwnode() which I find useful) pr_warn("%s: Link frequency estimanted using pixel rate: result might be inaccurate\n", __func__); pr_warn("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", __func___); Anyway, whatever works Reviewed-by: Jacopo Mondi Thanks j > if (!mul || !div) > return -ENOENT; > > -- > 2.17.1 >