From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFAEC4332B for ; Thu, 18 Feb 2021 12:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D42A61606 for ; Thu, 18 Feb 2021 12:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233069AbhBRMgJ (ORCPT ); Thu, 18 Feb 2021 07:36:09 -0500 Received: from foss.arm.com ([217.140.110.172]:50394 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232489AbhBRMKv (ORCPT ); Thu, 18 Feb 2021 07:10:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 030481FB; Thu, 18 Feb 2021 04:10:05 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF9863F73D; Thu, 18 Feb 2021 04:10:03 -0800 (PST) Date: Thu, 18 Feb 2021 12:09:02 +0000 From: Andre Przywara To: Alexandru Elisei Cc: Will Deacon , Julien Thierry , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Marc Zyngier Subject: Re: [PATCH kvmtool 07/21] hw/i8042: Switch to new trap handlers Message-ID: <20210218120902.630dcb2b@slackpad.fritz.box> In-Reply-To: References: <20201210142908.169597-1-andre.przywara@arm.com> <20201210142908.169597-8-andre.przywara@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 12 Feb 2021 10:41:20 +0000 Alexandru Elisei wrote: Hi, > On 12/10/20 2:28 PM, Andre Przywara wrote: > > Now that the PC keyboard has a trap handler adhering to the MMIO fault > > handler prototype, let's switch over to the joint registration routine. > > > > This allows us to get rid of the ioport shim routines. > > > > Make the kbd_init() function static on the way. > > > > Signed-off-by: Andre Przywara > > --- > > hw/i8042.c | 30 ++++-------------------------- > > include/kvm/i8042.h | 1 - > > 2 files changed, 4 insertions(+), 27 deletions(-) > > > > diff --git a/hw/i8042.c b/hw/i8042.c > > index eb1f9d28..91d79dc4 100644 > > --- a/hw/i8042.c > > +++ b/hw/i8042.c > > @@ -325,40 +325,18 @@ static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len, > > ioport__write8(data, value); > > } > > > > -/* > > - * Called when the OS has written to one of the keyboard's ports (0x60 or 0x64) > > - */ > > -static bool kbd_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, false, NULL); > > - > > - return true; > > -} > > - > > -static bool kbd_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, true, NULL); > > - > > - return true; > > -} > > - > > -static struct ioport_operations kbd_ops = { > > - .io_in = kbd_in, > > - .io_out = kbd_out, > > -}; > > - > > -int kbd__init(struct kvm *kvm) > > +static int kbd__init(struct kvm *kvm) > > { > > int r; > > > > kbd_reset(); > > state.kvm = kvm; > > - r = ioport__register(kvm, I8042_DATA_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_DATA_REG, 2, kbd_io, NULL); > > I guess you are registering two addresses here to cover I8042_PORT_B_REG, right? > Might be worth a comment. I am registering two ports because the original code did, and I didn't dare to touch this. I guess we put this on the wishlist for the device emulation fixup series? ;-) Maybe the intention was to just *reserve* those ports? > > > if (r < 0) > > return r; > > - r = ioport__register(kvm, I8042_COMMAND_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_COMMAND_REG, 2, kbd_io, NULL); > > Shouldn't length be 1? The emulation should work only for address 0x64 > (command/status register), right? Or am I missing something? I don't think you are, same as above. Maybe some weird guest is using half-word accesses (outw)? Cheers, Andre > > Thanks, > > Alex > > > if (r < 0) { > > - ioport__unregister(kvm, I8042_DATA_REG); > > + kvm__deregister_pio(kvm, I8042_DATA_REG); > > return r; > > } > > > > diff --git a/include/kvm/i8042.h b/include/kvm/i8042.h > > index 3b4ab688..cd4ae6bb 100644 > > --- a/include/kvm/i8042.h > > +++ b/include/kvm/i8042.h > > @@ -7,6 +7,5 @@ struct kvm; > > > > void mouse_queue(u8 c); > > void kbd_queue(u8 c); > > -int kbd__init(struct kvm *kvm); > > > > #endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A30BC433E0 for ; Thu, 18 Feb 2021 12:10:11 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 9371F64E6F for ; Thu, 18 Feb 2021 12:10:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9371F64E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EA3E44B397; Thu, 18 Feb 2021 07:10:08 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qbq3Ev6DaRKT; Thu, 18 Feb 2021 07:10:07 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A82494B3AD; Thu, 18 Feb 2021 07:10:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8988B4B326 for ; Thu, 18 Feb 2021 07:10:06 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vOgzwQdcZhr9 for ; Thu, 18 Feb 2021 07:10:05 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5F21B4B2F2 for ; Thu, 18 Feb 2021 07:10:05 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 030481FB; Thu, 18 Feb 2021 04:10:05 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF9863F73D; Thu, 18 Feb 2021 04:10:03 -0800 (PST) Date: Thu, 18 Feb 2021 12:09:02 +0000 From: Andre Przywara To: Alexandru Elisei Subject: Re: [PATCH kvmtool 07/21] hw/i8042: Switch to new trap handlers Message-ID: <20210218120902.630dcb2b@slackpad.fritz.box> In-Reply-To: References: <20201210142908.169597-1-andre.przywara@arm.com> <20201210142908.169597-8-andre.przywara@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Cc: kvm@vger.kernel.org, Marc Zyngier , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 12 Feb 2021 10:41:20 +0000 Alexandru Elisei wrote: Hi, > On 12/10/20 2:28 PM, Andre Przywara wrote: > > Now that the PC keyboard has a trap handler adhering to the MMIO fault > > handler prototype, let's switch over to the joint registration routine. > > > > This allows us to get rid of the ioport shim routines. > > > > Make the kbd_init() function static on the way. > > > > Signed-off-by: Andre Przywara > > --- > > hw/i8042.c | 30 ++++-------------------------- > > include/kvm/i8042.h | 1 - > > 2 files changed, 4 insertions(+), 27 deletions(-) > > > > diff --git a/hw/i8042.c b/hw/i8042.c > > index eb1f9d28..91d79dc4 100644 > > --- a/hw/i8042.c > > +++ b/hw/i8042.c > > @@ -325,40 +325,18 @@ static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len, > > ioport__write8(data, value); > > } > > > > -/* > > - * Called when the OS has written to one of the keyboard's ports (0x60 or 0x64) > > - */ > > -static bool kbd_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, false, NULL); > > - > > - return true; > > -} > > - > > -static bool kbd_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, true, NULL); > > - > > - return true; > > -} > > - > > -static struct ioport_operations kbd_ops = { > > - .io_in = kbd_in, > > - .io_out = kbd_out, > > -}; > > - > > -int kbd__init(struct kvm *kvm) > > +static int kbd__init(struct kvm *kvm) > > { > > int r; > > > > kbd_reset(); > > state.kvm = kvm; > > - r = ioport__register(kvm, I8042_DATA_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_DATA_REG, 2, kbd_io, NULL); > > I guess you are registering two addresses here to cover I8042_PORT_B_REG, right? > Might be worth a comment. I am registering two ports because the original code did, and I didn't dare to touch this. I guess we put this on the wishlist for the device emulation fixup series? ;-) Maybe the intention was to just *reserve* those ports? > > > if (r < 0) > > return r; > > - r = ioport__register(kvm, I8042_COMMAND_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_COMMAND_REG, 2, kbd_io, NULL); > > Shouldn't length be 1? The emulation should work only for address 0x64 > (command/status register), right? Or am I missing something? I don't think you are, same as above. Maybe some weird guest is using half-word accesses (outw)? Cheers, Andre > > Thanks, > > Alex > > > if (r < 0) { > > - ioport__unregister(kvm, I8042_DATA_REG); > > + kvm__deregister_pio(kvm, I8042_DATA_REG); > > return r; > > } > > > > diff --git a/include/kvm/i8042.h b/include/kvm/i8042.h > > index 3b4ab688..cd4ae6bb 100644 > > --- a/include/kvm/i8042.h > > +++ b/include/kvm/i8042.h > > @@ -7,6 +7,5 @@ struct kvm; > > > > void mouse_queue(u8 c); > > void kbd_queue(u8 c); > > -int kbd__init(struct kvm *kvm); > > > > #endif _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2ABC433E0 for ; Thu, 18 Feb 2021 12:11:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5658D64E2F for ; Thu, 18 Feb 2021 12:11:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5658D64E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eQ6Pka1Vn9w9VHAab/QHcxBAITGsI9cMo435nn30Wts=; b=YveYfZGtw/qVgzIZutkg2BkeI tKPPGgGt1xOPVCSbkurf+NwHmF8qwhpYr/wiyqldTzlkagg6wHP+nWLFw6rBDsSSS0wbeNwT6k07H nzC1Mo/UJ/Fhq0A9bw9VbTpl0iXGDMthG8vydihDcWFZbQdHvYXIojniPWBBHQHLf5AleHaC4TfRH ubvUU480dCu5Wf2yEFaJPEZWUAXk/DgZ/JuyzDOmlBbn0/coyFl+nwIWS1nZqxk/g/1Z8892h0olj mtVDCUbeHa/oZjhmtkSpMwWRsIclCovp416NYSl8LDgP3kpbgzJ5wNk+F9IWauv/eTGD9IPWwzF2X vPAhZBBXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCi8M-0003k7-H5; Thu, 18 Feb 2021 12:10:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCi8I-0003jb-Pi for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 12:10:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 030481FB; Thu, 18 Feb 2021 04:10:05 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF9863F73D; Thu, 18 Feb 2021 04:10:03 -0800 (PST) Date: Thu, 18 Feb 2021 12:09:02 +0000 From: Andre Przywara To: Alexandru Elisei Subject: Re: [PATCH kvmtool 07/21] hw/i8042: Switch to new trap handlers Message-ID: <20210218120902.630dcb2b@slackpad.fritz.box> In-Reply-To: References: <20201210142908.169597-1-andre.przywara@arm.com> <20201210142908.169597-8-andre.przywara@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_071011_101195_20E251C3 X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Marc Zyngier , Julien Thierry , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 12 Feb 2021 10:41:20 +0000 Alexandru Elisei wrote: Hi, > On 12/10/20 2:28 PM, Andre Przywara wrote: > > Now that the PC keyboard has a trap handler adhering to the MMIO fault > > handler prototype, let's switch over to the joint registration routine. > > > > This allows us to get rid of the ioport shim routines. > > > > Make the kbd_init() function static on the way. > > > > Signed-off-by: Andre Przywara > > --- > > hw/i8042.c | 30 ++++-------------------------- > > include/kvm/i8042.h | 1 - > > 2 files changed, 4 insertions(+), 27 deletions(-) > > > > diff --git a/hw/i8042.c b/hw/i8042.c > > index eb1f9d28..91d79dc4 100644 > > --- a/hw/i8042.c > > +++ b/hw/i8042.c > > @@ -325,40 +325,18 @@ static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len, > > ioport__write8(data, value); > > } > > > > -/* > > - * Called when the OS has written to one of the keyboard's ports (0x60 or 0x64) > > - */ > > -static bool kbd_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, false, NULL); > > - > > - return true; > > -} > > - > > -static bool kbd_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > > -{ > > - kbd_io(vcpu, port, data, size, true, NULL); > > - > > - return true; > > -} > > - > > -static struct ioport_operations kbd_ops = { > > - .io_in = kbd_in, > > - .io_out = kbd_out, > > -}; > > - > > -int kbd__init(struct kvm *kvm) > > +static int kbd__init(struct kvm *kvm) > > { > > int r; > > > > kbd_reset(); > > state.kvm = kvm; > > - r = ioport__register(kvm, I8042_DATA_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_DATA_REG, 2, kbd_io, NULL); > > I guess you are registering two addresses here to cover I8042_PORT_B_REG, right? > Might be worth a comment. I am registering two ports because the original code did, and I didn't dare to touch this. I guess we put this on the wishlist for the device emulation fixup series? ;-) Maybe the intention was to just *reserve* those ports? > > > if (r < 0) > > return r; > > - r = ioport__register(kvm, I8042_COMMAND_REG, &kbd_ops, 2, NULL); > > + r = kvm__register_pio(kvm, I8042_COMMAND_REG, 2, kbd_io, NULL); > > Shouldn't length be 1? The emulation should work only for address 0x64 > (command/status register), right? Or am I missing something? I don't think you are, same as above. Maybe some weird guest is using half-word accesses (outw)? Cheers, Andre > > Thanks, > > Alex > > > if (r < 0) { > > - ioport__unregister(kvm, I8042_DATA_REG); > > + kvm__deregister_pio(kvm, I8042_DATA_REG); > > return r; > > } > > > > diff --git a/include/kvm/i8042.h b/include/kvm/i8042.h > > index 3b4ab688..cd4ae6bb 100644 > > --- a/include/kvm/i8042.h > > +++ b/include/kvm/i8042.h > > @@ -7,6 +7,5 @@ struct kvm; > > > > void mouse_queue(u8 c); > > void kbd_queue(u8 c); > > -int kbd__init(struct kvm *kvm); > > > > #endif _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel