From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F13C433E0 for ; Thu, 18 Feb 2021 15:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9946464E85 for ; Thu, 18 Feb 2021 15:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbhBRPSu (ORCPT ); Thu, 18 Feb 2021 10:18:50 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2584 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231529AbhBRMXd (ORCPT ); Thu, 18 Feb 2021 07:23:33 -0500 Received: from fraeml711-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DhDC62qbhz67q3w; Thu, 18 Feb 2021 20:13:54 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Feb 2021 13:20:52 +0100 Received: from localhost (10.47.67.19) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Feb 2021 12:20:51 +0000 Date: Thu, 18 Feb 2021 12:19:48 +0000 From: Jonathan Cameron To: Alexandru Ardelean CC: , , , , , , Subject: Re: [PATCH v2 1/5] iio: Documentation: update definitions for bufferY and scan_elements Message-ID: <20210218121948.000017cd@Huawei.com> In-Reply-To: <20210217083438.37865-2-alexandru.ardelean@analog.com> References: <20210217083438.37865-1-alexandru.ardelean@analog.com> <20210217083438.37865-2-alexandru.ardelean@analog.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.67.19] X-ClientProxiedBy: lhreml732-chm.china.huawei.com (10.201.108.83) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Feb 2021 10:34:34 +0200 Alexandru Ardelean wrote: > Since the new change to the IIO buffer infrastructure, the buffer/ and > scan_elements/ directories have been merged into bufferY/ to have some > attributes available per-buffer. > > This change updates the ABI docs to reflect this change. > > The hwfifo attributes are not updated, as for now these should be used > via the legacy buffer/ directory until they are moved into core. > > Signed-off-by: Alexandru Ardelean This doesn't really have anything to do with the rest of the set - so ideally you'd have sent it separately. One trivial typo below, that I can fix whilst applying. > --- > Documentation/ABI/testing/sysfs-bus-iio | 85 +++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index d957f5da5c04..f2a72d7fbacb 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -1118,12 +1118,16 @@ Description: > > What: /sys/bus/iio/devices/iio:deviceX/buffer/length > KernelVersion: 2.6.35 > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/length > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > Number of scans contained by the buffer. > > What: /sys/bus/iio/devices/iio:deviceX/buffer/enable > KernelVersion: 2.6.35 > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/enable > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > Actually start the buffer capture up. Will start trigger > @@ -1131,11 +1135,16 @@ Description: > > What: /sys/bus/iio/devices/iio:deviceX/scan_elements > KernelVersion: 2.6.37 > +What: /sys/bus/iio/devices/iio:deviceX/buffeY bufferY I'll fix whilst applying. > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > Directory containing interfaces for elements that will be > captured for a single triggered sample set in the buffer. > > + Since kernel 5.11 the scan_elements attributes are merged into > + the bufferY directory, to be configurable per buffer. > + > What: /sys/.../iio:deviceX/scan_elements/in_accel_x_en > What: /sys/.../iio:deviceX/scan_elements/in_accel_y_en > What: /sys/.../iio:deviceX/scan_elements/in_accel_z_en > @@ -1164,6 +1173,34 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_en > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_en > What: /sys/.../iio:deviceX/scan_elements/in_proximity_en > KernelVersion: 2.6.37 > +What: /sys/.../iio:deviceX/bufferY/in_accel_x_en > +What: /sys/.../iio:deviceX/bufferY/in_accel_y_en > +What: /sys/.../iio:deviceX/bufferY/in_accel_z_en > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_x_en > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_y_en > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_z_en > +What: /sys/.../iio:deviceX/bufferY/in_magn_x_en > +What: /sys/.../iio:deviceX/bufferY/in_magn_y_en > +What: /sys/.../iio:deviceX/bufferY/in_magn_z_en > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_en > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_en > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_tilt_comp_en > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_tilt_comp_en > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_en > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_en > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_en > +What: /sys/.../iio:deviceX/bufferY/in_voltageY-voltageZ_en > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_en > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_en > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_en > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_en > +What: /sys/.../iio:deviceX/bufferY/in_incli_x_en > +What: /sys/.../iio:deviceX/bufferY/in_incli_y_en > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_en > +What: /sys/.../iio:deviceX/bufferY/in_pressure_en > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_en > +What: /sys/.../iio:deviceX/bufferY/in_proximity_en > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > Scan element control for triggered data capture. > @@ -1185,6 +1222,23 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_type > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_type > What: /sys/.../iio:deviceX/scan_elements/in_proximity_type > KernelVersion: 2.6.37 > +What: /sys/.../iio:deviceX/bufferY/in_accel_type > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_type > +What: /sys/.../iio:deviceX/bufferY/in_magn_type > +What: /sys/.../iio:deviceX/bufferY/in_incli_type > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_type > +What: /sys/.../iio:deviceX/bufferY/in_voltage_type > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_type > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_type > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_type > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_type > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_type > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_type > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_type > +What: /sys/.../iio:deviceX/bufferY/in_pressure_type > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_type > +What: /sys/.../iio:deviceX/bufferY/in_proximity_type > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > Description of the scan element data storage within the buffer > @@ -1241,6 +1295,33 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_index > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_index > What: /sys/.../iio:deviceX/scan_elements/in_proximity_index > KernelVersion: 2.6.37 > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_index > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_index > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_index > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_index > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_index > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_index > +What: /sys/.../iio:deviceX/bufferY/in_accel_x_index > +What: /sys/.../iio:deviceX/bufferY/in_accel_y_index > +What: /sys/.../iio:deviceX/bufferY/in_accel_z_index > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_x_index > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_y_index > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_z_index > +What: /sys/.../iio:deviceX/bufferY/in_magn_x_index > +What: /sys/.../iio:deviceX/bufferY/in_magn_y_index > +What: /sys/.../iio:deviceX/bufferY/in_magn_z_index > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_index > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_index > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_tilt_comp_index > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_tilt_comp_index > +What: /sys/.../iio:deviceX/bufferY/in_incli_x_index > +What: /sys/.../iio:deviceX/bufferY/in_incli_y_index > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_index > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_index > +What: /sys/.../iio:deviceX/bufferY/in_pressure_index > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_index > +What: /sys/.../iio:deviceX/bufferY/in_proximity_index > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > A single positive integer specifying the position of this > @@ -1455,6 +1536,8 @@ Description: > > What: /sys/bus/iio/devices/iio:deviceX/buffer/watermark > KernelVersion: 4.2 > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/watermark > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > A single positive integer specifying the maximum number of scan > @@ -1473,6 +1556,8 @@ Description: > > What: /sys/bus/iio/devices/iio:deviceX/buffer/data_available > KernelVersion: 4.16 > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/data_available > +KernelVersion: 5.11 > Contact: linux-iio@vger.kernel.org > Description: > A read-only value indicating the bytes of data available in the