From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C902C43331 for ; Thu, 18 Feb 2021 17:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20B9A64DFF for ; Thu, 18 Feb 2021 17:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232081AbhBRRIJ (ORCPT ); Thu, 18 Feb 2021 12:08:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33150 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231540AbhBROYw (ORCPT ); Thu, 18 Feb 2021 09:24:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613658192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B0Np6RmIQw2V0BL+Pl69+jda/IWr90txxGD9/gHBjqQ=; b=KcEFaySIemdJpk5jSG1d72JjVzCA2EwGUHsV/7hsGLKa5MwlkUA0E3Oo5EnhgfwDcwNz9B dRnmY1cVsRl7Slzv9HTVliQ785OE9HYptJUbDB1aKZGSU/KtlRPCsfdrXJpAKLhZyCS7ja KlzntGSmY9QXy01YuNLBCzlB4EWFmeI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-MrPlxZAFN1-CBrxEqE7XnQ-1; Thu, 18 Feb 2021 09:23:10 -0500 X-MC-Unique: MrPlxZAFN1-CBrxEqE7XnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D26980197C; Thu, 18 Feb 2021 14:23:09 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCD0019D9F; Thu, 18 Feb 2021 14:23:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9A48118000B7; Thu, 18 Feb 2021 15:23:06 +0100 (CET) Date: Thu, 18 Feb 2021 15:23:06 +0100 From: Gerd Hoffmann To: Thomas Zimmermann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" Subject: Re: [PATCH v2 10/11] drm/qxl: rework cursor plane Message-ID: <20210218142306.zlogw344is46q3yl@sirius.home.kraxel.org> References: <20210217123213.2199186-1-kraxel@redhat.com> <20210217123213.2199186-11-kraxel@redhat.com> <6a5581b2-8e62-1310-d42e-abfa301edc88@suse.de> <20210218115044.7tsi2szbdlw6lvdi@sirius.home.kraxel.org> <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Well. I suspect I could easily spend a month cleaning up and party > > redesign the qxl driver (specifically qxl_draw.c + qxl_image.c). > > > > I'm not sure I'll find the time to actually do that anytime soon. > > I have plenty of other stuff on my TODO list, and given that the > > world is transitioning to virtio-gpu the priority for qxl isn't > > that high. > > Well, in that case: > > Acked-by: Thomas Zimmermann > > for patches 9 and 10. Having the vmap calls fixed is at least worth it. Thanks. Any chance you can ack 8/11 too (only patch missing an ack). take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B95BC433DB for ; Thu, 18 Feb 2021 14:23:21 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93CDD64EB4 for ; Thu, 18 Feb 2021 14:23:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93CDD64EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DBCC0864F4; Thu, 18 Feb 2021 14:23:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lrw0DJCAhAg6; Thu, 18 Feb 2021 14:23:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id BDBCC8638F; Thu, 18 Feb 2021 14:23:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA71CC000F; Thu, 18 Feb 2021 14:23:18 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2E279C000D for ; Thu, 18 Feb 2021 14:23:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 13908605EF for ; Thu, 18 Feb 2021 14:23:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lS-VI92iWQ9P for ; Thu, 18 Feb 2021 14:23:15 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id CC5C8605FE; Thu, 18 Feb 2021 14:23:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 56144605EF for ; Thu, 18 Feb 2021 14:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613658193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B0Np6RmIQw2V0BL+Pl69+jda/IWr90txxGD9/gHBjqQ=; b=IMc1o8MaUhF0sbdADfGfpNSDQF5Dd7OeABoAci4CBNSmysHWIHxa/fONJcic23uUpG2UrT SgFKXGXgveSkES6A+np1Vzi/9ubbRON1dua9quMGHMPnt595w99YYUdg7iYgQzeyJBREPl 7B5hA6TgKuXRnR/GlDyHELiANXrlyfU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-MrPlxZAFN1-CBrxEqE7XnQ-1; Thu, 18 Feb 2021 09:23:10 -0500 X-MC-Unique: MrPlxZAFN1-CBrxEqE7XnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D26980197C; Thu, 18 Feb 2021 14:23:09 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCD0019D9F; Thu, 18 Feb 2021 14:23:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9A48118000B7; Thu, 18 Feb 2021 15:23:06 +0100 (CET) Date: Thu, 18 Feb 2021 15:23:06 +0100 From: Gerd Hoffmann To: Thomas Zimmermann Subject: Re: [PATCH v2 10/11] drm/qxl: rework cursor plane Message-ID: <20210218142306.zlogw344is46q3yl@sirius.home.kraxel.org> References: <20210217123213.2199186-1-kraxel@redhat.com> <20210217123213.2199186-11-kraxel@redhat.com> <6a5581b2-8e62-1310-d42e-abfa301edc88@suse.de> <20210218115044.7tsi2szbdlw6lvdi@sirius.home.kraxel.org> <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi, > > Well. I suspect I could easily spend a month cleaning up and party > > redesign the qxl driver (specifically qxl_draw.c + qxl_image.c). > > > > I'm not sure I'll find the time to actually do that anytime soon. > > I have plenty of other stuff on my TODO list, and given that the > > world is transitioning to virtio-gpu the priority for qxl isn't > > that high. > > Well, in that case: > > Acked-by: Thomas Zimmermann > > for patches 9 and 10. Having the vmap calls fixed is at least worth it. Thanks. Any chance you can ack 8/11 too (only patch missing an ack). take care, Gerd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C4B9C433E0 for ; Thu, 18 Feb 2021 14:23:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E2CA64E85 for ; Thu, 18 Feb 2021 14:23:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E2CA64E85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72AFF6EA0E; Thu, 18 Feb 2021 14:23:17 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F6266EA15 for ; Thu, 18 Feb 2021 14:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613658195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B0Np6RmIQw2V0BL+Pl69+jda/IWr90txxGD9/gHBjqQ=; b=IY12YJnlpy73B6PYZH0pH9RSrqxuPCXyFDRT1a6z30kBxKSxC4k8ySmkJm87JTsHgy+3TA E2uJOc/9jhysExhH5vyKkIkcQBWKzqv6x91MvXHcoigaEDu30/tpGYjCwhQ5kMBw7ZOvix eiPLnVIL5wk1GBb8L7lVoNxAPkVf56w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-MrPlxZAFN1-CBrxEqE7XnQ-1; Thu, 18 Feb 2021 09:23:10 -0500 X-MC-Unique: MrPlxZAFN1-CBrxEqE7XnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D26980197C; Thu, 18 Feb 2021 14:23:09 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCD0019D9F; Thu, 18 Feb 2021 14:23:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9A48118000B7; Thu, 18 Feb 2021 15:23:06 +0100 (CET) Date: Thu, 18 Feb 2021 15:23:06 +0100 From: Gerd Hoffmann To: Thomas Zimmermann Subject: Re: [PATCH v2 10/11] drm/qxl: rework cursor plane Message-ID: <20210218142306.zlogw344is46q3yl@sirius.home.kraxel.org> References: <20210217123213.2199186-1-kraxel@redhat.com> <20210217123213.2199186-11-kraxel@redhat.com> <6a5581b2-8e62-1310-d42e-abfa301edc88@suse.de> <20210218115044.7tsi2szbdlw6lvdi@sirius.home.kraxel.org> <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2d7a649c-bf1d-aa41-8d3c-af9746b94bc0@suse.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, > > Well. I suspect I could easily spend a month cleaning up and party > > redesign the qxl driver (specifically qxl_draw.c + qxl_image.c). > > > > I'm not sure I'll find the time to actually do that anytime soon. > > I have plenty of other stuff on my TODO list, and given that the > > world is transitioning to virtio-gpu the priority for qxl isn't > > that high. > > Well, in that case: > > Acked-by: Thomas Zimmermann > > for patches 9 and 10. Having the vmap calls fixed is at least worth it. Thanks. Any chance you can ack 8/11 too (only patch missing an ack). take care, Gerd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel