From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C7BC433E9 for ; Thu, 18 Feb 2021 18:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0B1564EBB for ; Thu, 18 Feb 2021 18:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233051AbhBRSr4 (ORCPT ); Thu, 18 Feb 2021 13:47:56 -0500 Received: from mail2.protonmail.ch ([185.70.40.22]:39313 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233714AbhBRQeA (ORCPT ); Thu, 18 Feb 2021 11:34:00 -0500 Date: Thu, 18 Feb 2021 16:33:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1613665996; bh=Xmnm25F8dJtzGykuyOII2OVkiSzMXlVCWeP0bkrqxBQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=TqLoqE2RZew5co5AF2tHpaZ018klI3mwIBQ5srfuK37W3zT0oo4WfBy3dBCK3MavL AXdUw/NZZeirXv4r7beTDYDNJJbjpSOXUN7bjoWuwqPpEwPxUHL0t9gV5LuERiTA0Q RbioLWjVbikyuV7F4RM0ZY8onHxGdVQPI6ERa0AI= To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, dan.carpenter@oracle.com, d.straghkov@ispras.ru, tiwai@suse.de From: Kurt Manucredo Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Kurt Manucredo Reply-To: Kurt Manucredo Subject: [PATCH] Staging: rtl8723bs: code-style fix Message-ID: <20210218163204.7-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Kurt Manucredo --- Checkpatch complains the constant needs to be on the right side of the comparison. The preferred way is:=20 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 089c6ec19373..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcu= r_dot11txpn, u8 *StaAddr) =09struct security_priv *psecpriv =3D &padapter->securitypriv; =20 =09memset(pcur_dot11txpn, 0, 8); -=09if (StaAddr =3D=3D NULL) +=09if (!StaAddr) =09=09return; =09psta =3D rtw_get_stainfo(&padapter->stapriv, StaAddr); =09DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", --=20 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CE1C433E0 for ; Thu, 18 Feb 2021 16:33:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4EF464E33 for ; Thu, 18 Feb 2021 16:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4EF464E33 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B84F5873E1; Thu, 18 Feb 2021 16:33:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7o6apDOEr0hd; Thu, 18 Feb 2021 16:33:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id CBCC2873B6; Thu, 18 Feb 2021 16:33:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 921021BF36C for ; Thu, 18 Feb 2021 16:33:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 80CAB60631 for ; Thu, 18 Feb 2021 16:33:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rntS6LkshBKQ for ; Thu, 18 Feb 2021 16:33:21 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id DA70A60699; Thu, 18 Feb 2021 16:33:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail-40136.protonmail.ch (mail-40136.protonmail.ch [185.70.40.136]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1125960697 for ; Thu, 18 Feb 2021 16:33:19 +0000 (UTC) Date: Thu, 18 Feb 2021 16:33:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1613665996; bh=Xmnm25F8dJtzGykuyOII2OVkiSzMXlVCWeP0bkrqxBQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=TqLoqE2RZew5co5AF2tHpaZ018klI3mwIBQ5srfuK37W3zT0oo4WfBy3dBCK3MavL AXdUw/NZZeirXv4r7beTDYDNJJbjpSOXUN7bjoWuwqPpEwPxUHL0t9gV5LuERiTA0Q RbioLWjVbikyuV7F4RM0ZY8onHxGdVQPI6ERa0AI= To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, dan.carpenter@oracle.com, d.straghkov@ispras.ru, tiwai@suse.de From: Kurt Manucredo Subject: [PATCH] Staging: rtl8723bs: code-style fix Message-ID: <20210218163204.7-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Kurt Manucredo Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Kurt Manucredo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Signed-off-by: Kurt Manucredo --- Checkpatch complains the constant needs to be on the right side of the comparison. The preferred way is: drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 089c6ec19373..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) struct security_priv *psecpriv = &padapter->securitypriv; memset(pcur_dot11txpn, 0, 8); - if (StaAddr == NULL) + if (!StaAddr) return; psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel