All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org
Subject: Re: led-gpios binding reporting a weird error
Date: Fri, 19 Feb 2021 10:24:50 +0100	[thread overview]
Message-ID: <20210219092450.vmfqucvwbq2aq3fc@gilmour> (raw)
In-Reply-To: <20210201095235.bfj7an4m47kom45n@gilmour>

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

On Mon, Feb 01, 2021 at 10:52:35AM +0100, Maxime Ripard wrote:
> On Thu, Jan 14, 2021 at 12:15:04PM +0100, Maxime Ripard wrote:
> > Hi Rob,
> > 
> > I just encountered a weird error with the led-gpios bindings.
> > 
> > Indeed, if we run, on today's next and the current master of the
> > dt-schema tools:
> > 
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml make -j18 dt_binding_check
> > 
> > we end up with:
> >   CHECK   Documentation/devicetree/bindings/leds/leds-gpio.example.dt.yaml
> > /home/max/Work/allwinner/build/arm64/Documentation/devicetree/bindings/leds/leds-gpio.example.dt.yaml: leds: led-1:default-state:0: 'keep' is not of type 'array'
> > 	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > /home/max/Work/allwinner/build/arm64/Documentation/devicetree/bindings/leds/leds-gpio.example.dt.yaml: run-control: led-0:default-state:0: 'off' is not of type 'array'
> > 	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > /home/max/Work/allwinner/build/arm64/Documentation/devicetree/bindings/leds/leds-gpio.example.dt.yaml: run-control: led-1:default-state:0: 'on' is not of type 'array'
> > 	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > 
> > What's being especially weird is that linux,default-trigger has the
> > exact same definition than default-state in leds/common.yaml (aside from
> > the set of valid values), and just works fine.
> > 
> > Changing the name of default-state to something else also doesn't change
> > anything, so it doesn't look like this is some other schema interfering.
> > Do you have an idea?
> 
> Ping? This error is still there on today's -next

and it looks like it's still there with yesterday's too

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2021-02-19  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 11:15 led-gpios binding reporting a weird error Maxime Ripard
2021-02-01  9:52 ` Maxime Ripard
2021-02-19  9:24   ` Maxime Ripard [this message]
2021-02-19 23:21     ` Rob Herring
2021-02-24  9:54       ` Maxime Ripard
2021-03-01 22:29         ` Rob Herring
2021-03-02 10:25           ` Maxime Ripard
2021-03-02 14:19             ` Rob Herring
2021-03-02 15:17               ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219092450.vmfqucvwbq2aq3fc@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.