All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: Re: [PATCH] ui/cocoa: Do not exit immediately after shutdown
Date: Fri, 19 Feb 2021 16:01:20 +0100	[thread overview]
Message-ID: <20210219150120.sjxs463znn46i2oh@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA_eKtZ--p=S9P7_9cEDxfvBVsb_aP4p6Luc+9XutGDxYA@mail.gmail.com>

> Gerd: I notice that the only ui frontends that try to do this
> SHUTDOWN_CAUSE_HOST_UI thing are the Cocoa UI and the SDL2 UI.
> The GTK UI does
>         qmp_quit()
> instead; the SDL2 UI does
>         shutdown_action = SHUTDOWN_ACTION_POWEROFF;
>         qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_UI);
> (presumably to avoid the "maybe the user told us to 'pause'"
> issue I mention above).

Seems so, qemu hangs in "[paused]" indeed when started with
-no-shutdown.

> None of the other UI frontends have
> any shutdown related handling. Shouldn't we be consistent
> about how we do this ?

Makes sense.  Probably best with a little 3-line helper called by all
UIs so we are consistent.

take care,
  Gerd



      parent reply	other threads:[~2021-02-19 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  8:46 [PATCH] ui/cocoa: Do not exit immediately after shutdown Akihiko Odaki
2021-02-19 10:21 ` Peter Maydell
2021-02-19 11:16   ` [PATCH v2] " Akihiko Odaki
2021-03-11 12:52     ` Gerd Hoffmann
2021-02-19 15:01   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219150120.sjxs463znn46i2oh@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.