From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 4/8] spl: fit: Remove useless loop in spl_fit_get_image_name()
Date: Fri, 19 Feb 2021 11:55:22 -0500 [thread overview]
Message-ID: <20210219165522.GR10169@bill-the-cat> (raw)
In-Reply-To: <20210120164656.1396639-5-mr.nuke.me@gmail.com>
On Wed, Jan 20, 2021 at 10:46:52AM -0600, Alexandru Gagniuc wrote:
> When a desired configuration is not found, conf_node will have a
> negative value. Thus the for loop will start at the root "/" node of
> the image, print the "/description" property, and stop.
>
> It appears the intent of the loop was to print the names of the
> subnodes under "/configurations". We would need the offset to the
> "/configurations" node, which is abstracted by fit_find_config_node().
>
> This change agrees that abstracting the node offset is the correct
> design, and we shouldn't be parsing the configurations manually. Thus
> the loop in spl_fit_get_image_name() is useless. Remove it.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210219/4ec7c897/attachment.sig>
next prev parent reply other threads:[~2021-02-19 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:46 [PATCH v4 0/8] spl: fit: Play nicely with OP-TEE and Linux Alexandru Gagniuc
2021-01-20 16:46 ` [PATCH v4 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load() Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 2/8] spl: fit: Factor out FIT parsing and use a context struct Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 3/8] spl: fit: Pass FIT context via a structure pointer Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 4/8] spl: fit: Remove useless loop in spl_fit_get_image_name() Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini [this message]
2021-01-20 16:46 ` [PATCH v4 5/8] spl: fit: Only look up FIT configuration node once Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 6/8] image: Do not #if guard board_fit_image_post_process() prototype Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 7/8] spl: fit: Replace #ifdef blocks with more readable constructs Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
2021-01-20 16:46 ` [PATCH v4 8/8] spl: fit: Load devicetree when a Linux payload is found Alexandru Gagniuc
2021-02-19 16:55 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219165522.GR10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.