From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B630C43381 for ; Sat, 20 Feb 2021 19:12:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30BC064EE9 for ; Sat, 20 Feb 2021 19:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbhBTTMS (ORCPT ); Sat, 20 Feb 2021 14:12:18 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:46492 "EHLO mail-wr1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhBTTMJ (ORCPT ); Sat, 20 Feb 2021 14:12:09 -0500 Received: by mail-wr1-f54.google.com with SMTP id t15so14485737wrx.13; Sat, 20 Feb 2021 11:11:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AP8Qz4CyqLCo3NhHxc8oaozrdLe2+NNTf4O5yIMTDZs=; b=MmkqC0XOCQPGR0+zzhT1p2L+eW2eYFkDOiwJ7c4+ibr1SwHVQzwxdOdtUescP2FZIH f57rdgIiI9sNRduGkhE95IuUFFP5QYKM9Chv5sd/pihbZ5xvf0KKOvM4Wz50e8w3KAAV QATWHjK1IMRp49DMRLNs/fvpaWjZxT91zMTzi+HNGWt63qYA1JGQ3EjDZXMdnd9i/PBx 3ZCRMlxY3dMVHefmw6MmtWJeKOh3pvd7vRB7VK4G3vvt6Iffhk82BkwQ5NBsfYequHYM c2zCMtMYxYMf7ZLfdN2Uis5dyluh9OmDrk5Qr2rU4VJYaJ/BfuXFN0EQfHlAfa4jVvhv gbYA== X-Gm-Message-State: AOAM5317w8kHSos0Uu/PA+JXemLYpQDYhYVEJI+F7JoiK6I6OS8Y8Cbo nx7XxROJjPyggvf26HY0evQ= X-Google-Smtp-Source: ABdhPJxBMP1FyAVRPUHU97bTnL2Py6n86AFr2ysvpg9k2xugwJ1xH2BjBMPhVY/EduC0v8exbqtj+g== X-Received: by 2002:adf:818a:: with SMTP id 10mr11367651wra.31.1613848287129; Sat, 20 Feb 2021 11:11:27 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id q140sm22790571wme.0.2021.02.20.11.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 11:11:26 -0800 (PST) Date: Sat, 20 Feb 2021 20:11:24 +0100 From: Krzysztof Kozlowski To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework Message-ID: <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-20-marcan@marcan.st> <20210215184012.sf6p6dbk5c25phdm@kozik-lap> <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: > > Separate patch for trivial renaming. > > I think it makes sense to do this rename together with the first change > above, as it keeps both functions symmetric. Otherwise we end up with an > inconsistent function naming between both patches. If you really want it > separate though, I can do that. OK, keep your version. > > > > > > > > > Signed-off-by: Hector Martin > > > --- > > > drivers/tty/serial/samsung_tty.c | 41 +++++++++++++++++++------------- > > > 1 file changed, 24 insertions(+), 17 deletions(-) > > > > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > > index 21955be680a4..821cd0e4f870 100644 > > > --- a/drivers/tty/serial/samsung_tty.c > > > +++ b/drivers/tty/serial/samsung_tty.c > > > @@ -151,6 +151,9 @@ struct s3c24xx_uart_port { > > > #endif > > > }; > > > +static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > > > +static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport); > > > + > > > /* conversion functions */ > > > #define s3c24xx_dev_to_port(__dev) dev_get_drvdata(__dev) > > > @@ -316,8 +319,6 @@ static void s3c24xx_serial_stop_tx(struct uart_port *port) > > > ourport->tx_mode = 0; > > > } > > > -static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > > > - > > > > Why moving this? Why adding s3c24xx_serial_tx_chars() forward > > declaration? > > This should've gone in the next patch. A previous reviewer told me to put > declarations at the top of the file, so I put it there and moved this one > along with it, but I'll keep it to the additon only for v3. Maybe I missed something in the context but it looked like forward declaration s3c24xx_serial_tx_chars() was not needed? In such case no need to move it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6B6C433E0 for ; Sat, 20 Feb 2021 19:13:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCCEF64EB3 for ; Sat, 20 Feb 2021 19:13:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCCEF64EB3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pcPm0XfgjYy9D+x2U9Fx0SJqu3O3iW/liXNttCJfqNY=; b=kSOWI193qtHM7r9qZzxh3w6GM eErmBMi3Mwp+doUkJr66nGuGCkH2uYo9J12GQuKXDi3v/aED5Qxs4+RhX7BNQr+DyglJjw96+F79n c1KaqcFBBadaMVuLR6RO4pllw6hXvqv25RL8Svjc7EcgatmZJzkExdRE3m9cXdn506yPuX3ZNLAS7 pTPfruLUM1TX8PGwk0HEd6zJgJ5mL3dKt3Z018tTLZv05c54WGwuEavJqCVg4zibNv9PAFsguFh6i MGuRdq08fDzjdf0GE+j/+ejp6CB3hTb075XnRhTGeojWRFyyiJqjwCD2oB8z6THSDOqqIZ2UgoF6k Z1mHMXHZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXfB-0003I5-2d; Sat, 20 Feb 2021 19:11:33 +0000 Received: from mail-wr1-f52.google.com ([209.85.221.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXf8-0003HO-Tw for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 19:11:31 +0000 Received: by mail-wr1-f52.google.com with SMTP id 7so14569644wrz.0 for ; Sat, 20 Feb 2021 11:11:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AP8Qz4CyqLCo3NhHxc8oaozrdLe2+NNTf4O5yIMTDZs=; b=M2qo9D1h/SVoghN1LHxUJAEsAhqcwfojFClg/9F1DGtNz3jX6kARWoZewTf5pVXV/3 eK4guuxnPXct0hYwmM2xyk7Vkr8vbKo1aWKC4nmUZtVkQju8MDKmR79pJWxvnGv8zKfs NKUZewd2MltWNK13MtEjCZrDhYub28JgjjaYeawbOw5re4HeEUv/WZGgZKOV8h5ZDjNP rz1YLz2MxAtVLjNkHlFEkoNz2OkNseemumaZwUCtxX7W3Wk/MZOPK3Lg/vUxlA1Qi887 /DQ/aaPYY8PwiN9DUPL6hVu30lV0NzgNgWKFGgrVcngXR4XWCgQnegSTo0Y6Q38/i5nz LFRw== X-Gm-Message-State: AOAM533Fa4tZoW9zcaqMCh3ZZkSEba6aCFBZjn9j1KJp6K+ifRvHqDvc FNT0S++kyZec9s4PMpEiaAk= X-Google-Smtp-Source: ABdhPJxBMP1FyAVRPUHU97bTnL2Py6n86AFr2ysvpg9k2xugwJ1xH2BjBMPhVY/EduC0v8exbqtj+g== X-Received: by 2002:adf:818a:: with SMTP id 10mr11367651wra.31.1613848287129; Sat, 20 Feb 2021 11:11:27 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id q140sm22790571wme.0.2021.02.20.11.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 11:11:26 -0800 (PST) Date: Sat, 20 Feb 2021 20:11:24 +0100 From: Krzysztof Kozlowski To: Hector Martin Subject: Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework Message-ID: <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-20-marcan@marcan.st> <20210215184012.sf6p6dbk5c25phdm@kozik-lap> <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_141131_002914_ACD111D5 X-CRM114-Status: GOOD ( 23.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: > > Separate patch for trivial renaming. > > I think it makes sense to do this rename together with the first change > above, as it keeps both functions symmetric. Otherwise we end up with an > inconsistent function naming between both patches. If you really want it > separate though, I can do that. OK, keep your version. > > > > > > > > > Signed-off-by: Hector Martin > > > --- > > > drivers/tty/serial/samsung_tty.c | 41 +++++++++++++++++++------------- > > > 1 file changed, 24 insertions(+), 17 deletions(-) > > > > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > > index 21955be680a4..821cd0e4f870 100644 > > > --- a/drivers/tty/serial/samsung_tty.c > > > +++ b/drivers/tty/serial/samsung_tty.c > > > @@ -151,6 +151,9 @@ struct s3c24xx_uart_port { > > > #endif > > > }; > > > +static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > > > +static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport); > > > + > > > /* conversion functions */ > > > #define s3c24xx_dev_to_port(__dev) dev_get_drvdata(__dev) > > > @@ -316,8 +319,6 @@ static void s3c24xx_serial_stop_tx(struct uart_port *port) > > > ourport->tx_mode = 0; > > > } > > > -static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > > > - > > > > Why moving this? Why adding s3c24xx_serial_tx_chars() forward > > declaration? > > This should've gone in the next patch. A previous reviewer told me to put > declarations at the top of the file, so I put it there and moved this one > along with it, but I'll keep it to the additon only for v3. Maybe I missed something in the context but it looked like forward declaration s3c24xx_serial_tx_chars() was not needed? In such case no need to move it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel