From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78381C433E0 for ; Sat, 20 Feb 2021 23:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B4CC64EB8 for ; Sat, 20 Feb 2021 23:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbhBTXNI (ORCPT ); Sat, 20 Feb 2021 18:13:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:58332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhBTXMs (ORCPT ); Sat, 20 Feb 2021 18:12:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51D9664EB8; Sat, 20 Feb 2021 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613862726; bh=u7qHB3S8G0lDGgctj7hnk3Ftm2wmMqZUJjxJBtDhpoc=; h=From:To:Cc:Subject:Date:From; b=UodP6zDtTn2rRt4+ehbVCIW17ZhEeFqUvsdVPd3AtqHA/4qMCvYrcMUfBAyvkIxxE iolOJx4zAZ4rGDwpe/J1/qcEYjThxGJEEGVG0GEsEagBhf/rqGS9svyIwwikGShnNp oQDyWWm8GLipj7RmEQqFLhp+q9dHupSLChJY1X5Zxo1if/4UB0tqjTzH9Q33YiYK6z Pg4gPROOMnnfHDZhK7w7sh56FVWJgGSSX4ZHOuQFsKQeqW17tsnG2LT56tA9WhjzcL qwLadqhl1tLgfOO4enBPGnwMxa7L8mWBhWo0nEO3aSMCEXbLPqk+ZHzRpf36rRxKhd pFYAYcAcfN7SQ== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Gregory CLEMENT Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , Rui Salvaterra , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, Andrew Lunn , stable@vger.kernel.org Subject: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Date: Sun, 21 Feb 2021 00:11:44 +0100 Message-Id: <20210220231144.32325-1-kabel@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. Without this the pin is by default in LED[2] mode, and the Marvell PHY driver configures LED[2] into "On - Link, Blink - Activity" mode. This fixes the issue where the pca9538 GPIO/interrupt controller (which can't mask interrupts in HW) received too many interrupts and after a time started ignoring the interrupt with error message: IRQ 71: nobody cared There is a work in progress to have the Marvell PHY driver support parsing PHY LED nodes from OF and registering the LEDs as Linux LED class devices. Once this is done the PHY driver can also automatically set the pin into INTn mode if it does not find LED[2] in OF. Until then, though, we fix this via `marvell,reg-init` DT property. Signed-off-by: Marek Behún Reported-by: Rui Salvaterra Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") Cc: Uwe Kleine-König Cc: linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn Cc: Gregory CLEMENT Cc: --- This patch fixes bug introduced with the commit that added Turris Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is commit 8ee4a5f4f40d which changed node name and node compatible property and this commit did not go into stable. So either commit 8ee4a5f4f40d has also to go into stable before this, or this patch has to be fixed a little in order to apply to 4.14+. Please let me know how should I handle this. --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index 646a06420c77..b0f3fd8e1429 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -389,6 +389,7 @@ &mdio { phy1: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; + marvell,reg-init = <3 18 0 0x4985>; /* irq is connected to &pcawan pin 7 */ }; -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED5EC433DB for ; Sat, 20 Feb 2021 23:14:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E47CF64DED for ; Sat, 20 Feb 2021 23:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E47CF64DED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=a7Ag7mD1UB04G2JZWaVIEvZtaJXefVnCCbxA6J/OIVw=; b=Fb9ikhNJGZe8p6hF81iGNG0beI Ylyl80jUXz+HfOYTOZn0646toe5ADVACj0EI5QhyXVDncOxQ7f99u9UP0Ma26AiJmrLsZT3WL6pDD isakViEwSk54xxSRchqQRnx9++f5TDj8on1Mf/j+j4eH7RQ4nBJD+P01eEv31i8MYAo8JWJwl1kHB RInsmXlH6E41BxpBtEQc5i5HHs1JutujxE0HP1ce9FD5l5XH18H/24saq/6cdYJtV1j099Sc/6Pm2 C4OethCGSsmpbvos8fkOmdwUZNCkl3B9451DlsLYFtNuSty6CPyVQnfuMH9eE1mSr9WuDmvKinKk8 p++2aOKg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDbQ3-0003rw-92; Sat, 20 Feb 2021 23:12:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDbQ0-0003rO-CF for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 23:12:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51D9664EB8; Sat, 20 Feb 2021 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613862726; bh=u7qHB3S8G0lDGgctj7hnk3Ftm2wmMqZUJjxJBtDhpoc=; h=From:To:Cc:Subject:Date:From; b=UodP6zDtTn2rRt4+ehbVCIW17ZhEeFqUvsdVPd3AtqHA/4qMCvYrcMUfBAyvkIxxE iolOJx4zAZ4rGDwpe/J1/qcEYjThxGJEEGVG0GEsEagBhf/rqGS9svyIwwikGShnNp oQDyWWm8GLipj7RmEQqFLhp+q9dHupSLChJY1X5Zxo1if/4UB0tqjTzH9Q33YiYK6z Pg4gPROOMnnfHDZhK7w7sh56FVWJgGSSX4ZHOuQFsKQeqW17tsnG2LT56tA9WhjzcL qwLadqhl1tLgfOO4enBPGnwMxa7L8mWBhWo0nEO3aSMCEXbLPqk+ZHzRpf36rRxKhd pFYAYcAcfN7SQ== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Gregory CLEMENT Subject: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Date: Sun, 21 Feb 2021 00:11:44 +0100 Message-Id: <20210220231144.32325-1-kabel@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_181208_605297_E8F22220 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , Andrew Lunn , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , stable@vger.kernel.org, Rui Salvaterra , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXNlIHRoZSBgbWFydmVsbCxyZWctaW5pdGAgRFQgcHJvcGVydHkgdG8gY29uZmlndXJlIHRoZSBM RURbMl0vSU5UbiBwaW4Kb2YgdGhlIE1hcnZlbGwgODhFMTUxNCBldGhlcm5ldCBQSFkgb24gVHVy cmlzIE9tbmlhIGludG8gaW50ZXJydXB0IG1vZGUuCgpXaXRob3V0IHRoaXMgdGhlIHBpbiBpcyBi eSBkZWZhdWx0IGluIExFRFsyXSBtb2RlLCBhbmQgdGhlIE1hcnZlbGwgUEhZCmRyaXZlciBjb25m aWd1cmVzIExFRFsyXSBpbnRvICJPbiAtIExpbmssIEJsaW5rIC0gQWN0aXZpdHkiIG1vZGUuCgpU aGlzIGZpeGVzIHRoZSBpc3N1ZSB3aGVyZSB0aGUgcGNhOTUzOCBHUElPL2ludGVycnVwdCBjb250 cm9sbGVyICh3aGljaApjYW4ndCBtYXNrIGludGVycnVwdHMgaW4gSFcpIHJlY2VpdmVkIHRvbyBt YW55IGludGVycnVwdHMgYW5kIGFmdGVyIGEKdGltZSBzdGFydGVkIGlnbm9yaW5nIHRoZSBpbnRl cnJ1cHQgd2l0aCBlcnJvciBtZXNzYWdlOgogIElSUSA3MTogbm9ib2R5IGNhcmVkCgpUaGVyZSBp cyBhIHdvcmsgaW4gcHJvZ3Jlc3MgdG8gaGF2ZSB0aGUgTWFydmVsbCBQSFkgZHJpdmVyIHN1cHBv cnQKcGFyc2luZyBQSFkgTEVEIG5vZGVzIGZyb20gT0YgYW5kIHJlZ2lzdGVyaW5nIHRoZSBMRURz IGFzIExpbnV4IExFRApjbGFzcyBkZXZpY2VzLiBPbmNlIHRoaXMgaXMgZG9uZSB0aGUgUEhZIGRy aXZlciBjYW4gYWxzbyBhdXRvbWF0aWNhbGx5CnNldCB0aGUgcGluIGludG8gSU5UbiBtb2RlIGlm IGl0IGRvZXMgbm90IGZpbmQgTEVEWzJdIGluIE9GLgoKVW50aWwgdGhlbiwgdGhvdWdoLCB3ZSBm aXggdGhpcyB2aWEgYG1hcnZlbGwscmVnLWluaXRgIERUIHByb3BlcnR5LgoKU2lnbmVkLW9mZi1i eTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJuZWwub3JnPgpSZXBvcnRlZC1ieTogUnVpIFNhbHZh dGVycmEgPHJzYWx2YXRlcnJhQGdtYWlsLmNvbT4KRml4ZXM6IDI2Y2E4YjUyZDZlMSAoIkFSTTog ZHRzOiBhZGQgc3VwcG9ydCBmb3IgVHVycmlzIE9tbmlhIikKQ2M6IFV3ZSBLbGVpbmUtS8O2bmln IDx1d2VAa2xlaW5lLWtvZW5pZy5vcmc+CkNjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKQ2M6IEFuZHJldyBMdW5uIDxhbmRyZXdAbHVubi5jaD4KQ2M6IEdyZWdvcnkgQ0xF TUVOVCA8Z3JlZ29yeS5jbGVtZW50QGJvb3RsaW4uY29tPgpDYzogPHN0YWJsZUB2Z2VyLmtlcm5l bC5vcmc+CgotLS0KClRoaXMgcGF0Y2ggZml4ZXMgYnVnIGludHJvZHVjZWQgd2l0aCB0aGUgY29t bWl0IHRoYXQgYWRkZWQgVHVycmlzCk9tbmlhJ3MgRFRTICgyNmNhOGI1MmQ2ZTEpLCBidXQgd2ls bCBub3QgYXBwbHkgY2xlYW5seSBiZWNhdXNlIHRoZXJlIGlzCmNvbW1pdCA4ZWU0YTVmNGY0MGQg d2hpY2ggY2hhbmdlZCBub2RlIG5hbWUgYW5kIG5vZGUgY29tcGF0aWJsZQpwcm9wZXJ0eSBhbmQg dGhpcyBjb21taXQgZGlkIG5vdCBnbyBpbnRvIHN0YWJsZS4KClNvIGVpdGhlciBjb21taXQgOGVl NGE1ZjRmNDBkIGhhcyBhbHNvIHRvIGdvIGludG8gc3RhYmxlIGJlZm9yZSB0aGlzLCBvcgp0aGlz IHBhdGNoIGhhcyB0byBiZSBmaXhlZCBhIGxpdHRsZSBpbiBvcmRlciB0byBhcHBseSB0byA0LjE0 Ky4KClBsZWFzZSBsZXQgbWUga25vdyBob3cgc2hvdWxkIEkgaGFuZGxlIHRoaXMuCgotLS0KIGFy Y2gvYXJtL2Jvb3QvZHRzL2FybWFkYS0zODUtdHVycmlzLW9tbmlhLmR0cyB8IDEgKwogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMv YXJtYWRhLTM4NS10dXJyaXMtb21uaWEuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvYXJtYWRhLTM4 NS10dXJyaXMtb21uaWEuZHRzCmluZGV4IDY0NmEwNjQyMGM3Ny4uYjBmM2ZkOGUxNDI5IDEwMDY0 NAotLS0gYS9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEtMzg1LXR1cnJpcy1vbW5pYS5kdHMKKysr IGIvYXJjaC9hcm0vYm9vdC9kdHMvYXJtYWRhLTM4NS10dXJyaXMtb21uaWEuZHRzCkBAIC0zODks NiArMzg5LDcgQEAgJm1kaW8gewogCXBoeTE6IGV0aGVybmV0LXBoeUAxIHsKIAkJY29tcGF0aWJs ZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiI7CiAJCXJlZyA9IDwxPjsKKwkJbWFydmVs bCxyZWctaW5pdCA9IDwzIDE4IDAgMHg0OTg1PjsKIAogCQkvKiBpcnEgaXMgY29ubmVjdGVkIHRv ICZwY2F3YW4gcGluIDcgKi8KIAl9OwotLSAKMi4yNi4yCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=