From: Steven Rostedt <rostedt@goodmis.org>
To: Sameeruddin Shaik <sameeruddin.shaik8@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtracefs: New API to trace only specific functions by instance
Date: Sun, 21 Feb 2021 10:28:21 -0500 [thread overview]
Message-ID: <20210221102821.1b6f13bd@oasis.local.home> (raw)
In-Reply-To: <CAK7tX=bRRtcsAPWuiF8i5T2WnO_kSMKY7ar01f3Ki4awAC08rQ@mail.gmail.com>
On Mon, 22 Feb 2021 18:10:40 +0530
Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:
> hi steve,
> As you suggested, i have used an array of const pointers to const strings.
> This is the version-1 of the patch, it breaks in write.
> I faced two problems here
> 1. The above code can't be able to write to set_ftrace_filter file
> string by string (for normal files its working fine), After every
> successful write i am getting the count bytes written as supplied
> size, but strings are not getting written in the set_ftrace_filter
> file. please give me any review or debug inputs on this
I'll take a look at your patch tomorrow.
> 2.I don't know how to reply to previous thread using git send-email, i
> apologize for that, please do let me know how to reply to the older
> threads
> using the git send-email.
Why do you need to reply to the previous thread with git send-email.
New versions of a patch should be their own thread and not a reply to
another thread.
That said, if you look at the headers of the email you want to reply
to, you'll see a Message-ID field. For example, your email that I'm
replying to has the message id of:
Message-ID: <CAK7tX=bRRtcsAPWuiF8i5T2WnO_kSMKY7ar01f3Ki4awAC08rQ@mail.gmail.com>
Then I can use the part in between the '<' and '>' to send replies via
git send-email.
git send-email '--in-reply-to=CAK7tX=bRRtcsAPWuiF8i5T2WnO_kSMKY7ar01f3Ki4awAC08rQ@mail.gmail.com'
Note the quotes used above. They may be needed to prevent bash from
interpreting anything inside the message ID.
And then the emails sent from git will be a reply to that email.
> Once i have the write functionality working fine, will implement the
> other features incrementally.
OK. Again, I'll take a look at your patch on Monday.
Thanks,
-- Steve
next prev parent reply other threads:[~2021-02-21 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH][WIP]libtracefs:New API to enable the filtering of functions>
2021-02-22 12:24 ` [PATCH] libtracefs: New API to trace only specific functions by instance Sameeruddin shaik
2021-02-22 12:40 ` Sameeruddin Shaik
2021-02-21 15:28 ` Steven Rostedt [this message]
2021-02-22 14:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221102821.1b6f13bd@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sameeruddin.shaik8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.