From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED84C433DB for ; Sun, 21 Feb 2021 11:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A72B64EE0 for ; Sun, 21 Feb 2021 11:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbhBULak (ORCPT ); Sun, 21 Feb 2021 06:30:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:54696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbhBULaj (ORCPT ); Sun, 21 Feb 2021 06:30:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 695B964EE9; Sun, 21 Feb 2021 11:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613906998; bh=Ii6mCKLdMk+Svk1KpodaVpXsreuwHJe163Dne4id3BY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d2UE9/90wdqjqqFrZcVN+lTrlsYm+8czUPx5JO6BrG/WVVOqbOaiL5ATqk5/0egaE dJnljpBaBvbmOplzqcx01DAQBW0CuXXdMjM4XR41EMTG+zVaeZxCGgTQEVIp7ddpLM RVo4YCqXp22TWQUr7E5zuS8OCeJb76svRj3Ccff10+KuxERfmJf6zNcAuMlL0nhp1D uSRJjtz3c3vJv0iphQWJ+Zqe02+q4i2M2cU54DLVi/FzKQPCCAFjtZSjlPg8ru2FLc 0gobWBdFuswyDj1IUlaQjrID+S7n3t4QN/OMH3ktSdvT/7lJ/YkVgGFb4+DHm2Omi9 DZu7SBcagsfLA== Date: Sun, 21 Feb 2021 12:29:55 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Hans de Goede Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-leds@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 2/7] HID: lenovo: Fix lenovo_led_set_tp10ubkbd() error handling Message-ID: <20210221122955.2f933b14@kernel.org> In-Reply-To: <20210221112005.102116-3-hdegoede@redhat.com> References: <20210221112005.102116-1-hdegoede@redhat.com> <20210221112005.102116-3-hdegoede@redhat.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Reviewed-by: Marek Beh=C3=BAn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2B7C433DB for ; Thu, 25 Feb 2021 11:27:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1A5164EF5 for ; Thu, 25 Feb 2021 11:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1A5164EF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 282591662; Thu, 25 Feb 2021 12:26:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 282591662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614252434; bh=Ii6mCKLdMk+Svk1KpodaVpXsreuwHJe163Dne4id3BY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LLLxJNgBtsc3ZsYMeDRLQifrWnGYmGrWKruOM7TblvTpNuMcsBkuaxKcJi2uN2vQh dAKZ1Y0VPDCsHlMkv9oFilNPNQBEC9yndBtH7KvGCCZAHYYRInTfrPryUoJYb9ZM8x K0gSOtAUJVVcTot3i1EnVuHljFHg/K4MTTEQQoGA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8E7CCF80245; Thu, 25 Feb 2021 12:25:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15520F8016D; Sun, 21 Feb 2021 12:30:05 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 75DB6F800F3 for ; Sun, 21 Feb 2021 12:30:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 75DB6F800F3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d2UE9/90" Received: by mail.kernel.org (Postfix) with ESMTPSA id 695B964EE9; Sun, 21 Feb 2021 11:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613906998; bh=Ii6mCKLdMk+Svk1KpodaVpXsreuwHJe163Dne4id3BY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d2UE9/90wdqjqqFrZcVN+lTrlsYm+8czUPx5JO6BrG/WVVOqbOaiL5ATqk5/0egaE dJnljpBaBvbmOplzqcx01DAQBW0CuXXdMjM4XR41EMTG+zVaeZxCGgTQEVIp7ddpLM RVo4YCqXp22TWQUr7E5zuS8OCeJb76svRj3Ccff10+KuxERfmJf6zNcAuMlL0nhp1D uSRJjtz3c3vJv0iphQWJ+Zqe02+q4i2M2cU54DLVi/FzKQPCCAFjtZSjlPg8ru2FLc 0gobWBdFuswyDj1IUlaQjrID+S7n3t4QN/OMH3ktSdvT/7lJ/YkVgGFb4+DHm2Omi9 DZu7SBcagsfLA== Date: Sun, 21 Feb 2021 12:29:55 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Hans de Goede Subject: Re: [PATCH v3 2/7] HID: lenovo: Fix lenovo_led_set_tp10ubkbd() error handling Message-ID: <20210221122955.2f933b14@kernel.org> In-Reply-To: <20210221112005.102116-3-hdegoede@redhat.com> References: <20210221112005.102116-1-hdegoede@redhat.com> <20210221112005.102116-3-hdegoede@redhat.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 25 Feb 2021 12:25:30 +0100 Cc: Benjamin Tissoires , alsa-devel@alsa-project.org, Jiri Kosina , linux-leds@vger.kernel.org, linux-input@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Reviewed-by: Marek Beh=C3=BAn