From: Jonathan Cameron <jic23@kernel.org>
To: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: vcnl3020: add proximity rate in hz
Date: Sun, 21 Feb 2021 15:09:07 +0000 [thread overview]
Message-ID: <20210221150907.2161b964@archlinux> (raw)
In-Reply-To: <20210216145346.18304-3-i.mikhaylov@yadro.com>
On Tue, 16 Feb 2021 17:53:46 +0300
Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
> Describe the possible proximity values in herzes for vcnl3020.
Hertz
Why does this belong in DT?
DT bindings should reflect physical characteristics of the device, so how
is wired up, whether there are plastic windows over it that might affect
calibration - that sort of thing. A rate of sampling proximity seems
like a policy decision best left to user space.
Jonathan
>
> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
> ---
> .../devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> index fbd3a2e32280..1bb6ca1770f3 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> @@ -43,6 +43,12 @@ properties:
> 180000, 190000, 200000]
> default: 20000
>
> + vishay,proximity-rate-hz:
> + description:
> + The rate of proximity measurement.
> + enum: [1, 3, 7, 16, 31, 62, 125, 500]
> + default: 1
> +
> required:
> - compatible
> - reg
prev parent reply other threads:[~2021-02-21 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:53 [PATCH 0/2] add proximity rate option for vcnl3020 Ivan Mikhaylov
2021-02-16 14:53 ` [PATCH 1/2] iio: proximity: vcnl3020: add proximity rate Ivan Mikhaylov
2021-02-21 15:20 ` Jonathan Cameron
2021-02-24 15:20 ` Ivan Mikhaylov
[not found] ` <CAHp75VeFE3BMB+siM4xfnmsgW8=67bgOSmYHseAY++3_ds16XA@mail.gmail.com>
2021-02-24 15:27 ` Ivan Mikhaylov
2021-02-16 14:53 ` [PATCH 2/2] dt-bindings: vcnl3020: add proximity rate in hz Ivan Mikhaylov
2021-02-21 15:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221150907.2161b964@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=i.mikhaylov@yadro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.