From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D011C433E0 for ; Sun, 21 Feb 2021 16:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C9464E5F for ; Sun, 21 Feb 2021 16:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbhBUQQo (ORCPT ); Sun, 21 Feb 2021 11:16:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:50902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhBUQQo (ORCPT ); Sun, 21 Feb 2021 11:16:44 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6478464EF1; Sun, 21 Feb 2021 16:16:01 +0000 (UTC) Date: Sun, 21 Feb 2021 16:15:57 +0000 From: Jonathan Cameron To: Gwendal Grignou Cc: gabriele.mzt@gmail.com, lars@metafoo.de, andy.shevchenko@gmail.com, linux-iio@vger.kernel.org Subject: Re: [PATCH v5 0/3] iio: acpi_als: Add sotfware trigger support Message-ID: <20210221161557.6515ca90@archlinux> In-Reply-To: <20201229173910.378e559f@archlinux> References: <20201229015300.3037816-1-gwendal@chromium.org> <20201229173910.378e559f@archlinux> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 29 Dec 2020 17:39:10 +0000 Jonathan Cameron wrote: > On Mon, 28 Dec 2020 17:52:57 -0800 > Gwendal Grignou wrote: > > > Some devices (chromebooks) present the ACPI ALS device but do not have > > ability to notify when a new sample is present. > > Add support for software trigger (hrtimer/sysfs-trigger) to allow > > retrieving samples using iio buffers. > > > > The first path fully adds timestamp channel, the second adds a local > > variable in probe routine and the last one adds trigger support. > > > > This patch assumes the patch "iio: set default trig->dev.parent" is > > applied. > I'm asking for a rebase of that series. Otherwise this looks good to me Hi Gwendal, Given the dependency isn't ready yet, please resend this series once it is in place. Thanks, Jonathan > > Thanks, > > Jonathan > > > > > > > Gwendal Grignou (3): > > iio: acpi_als: Add timestamp channel > > iio: acpi_als: Add local variable dev in probe > > iio: acpi_als: Add trigger support > > > > drivers/iio/light/acpi-als.c | 121 +++++++++++++++++++++++------------ > > 1 file changed, 81 insertions(+), 40 deletions(-) > > >