All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: stable@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Trent Piepho <tpiepho@gmail.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Hilda Wu <hildawu@realtek.com>,
	Sathish Narasimman <sathish.narasimman@intel.com>,
	Chethan T N <chethan.tumkur.narayan@intel.com>,
	Hsin-Yu Chao <hychao@chromium.org>,
	Amit K Bag <amit.k.bag@intel.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	kernel@collabora.com, Sjoerd Simons <sjoerd@collabora.com>
Subject: Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS
Date: Sun, 21 Feb 2021 21:35:57 +0100	[thread overview]
Message-ID: <20210221203557.wcmukv77sng25bql@earth.universe> (raw)
In-Reply-To: <YB68RUVLRGQKS+yH@dawn.lan>

[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]

[+cc stable@vger.kernel.org]

Hi,

On Sat, Feb 06, 2021 at 04:56:53PM +0100, Sjoerd Simons wrote:
> On Fri, Dec 18, 2020 at 10:23:08PM +0100, Marcel Holtmann wrote:
> > Hi Trent,
> > 
> > > When alt mode 6 is not available, fallback to the kernel <= 5.7 behavior
> > > of always using alt mode 1.
> > > 
> > > Prior to kernel 5.8, btusb would always use alt mode 1 for WBS (Wide
> > > Band Speech aka mSBC aka transparent SCO).  In commit baac6276c0a9
> > > ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") this
> > > was changed to use alt mode 6, which is the recommended mode in the
> > > Bluetooth spec (Specifications of the Bluetooth System, v5.0, Vol 4.B
> > > §2.2.1).  However, many if not most BT USB adapters do not support alt
> > > mode 6.  In fact, I have been unable to find any which do.
> 
> > patch has been applied to bluetooth-next tree.
> 
> For easier application to the stable tree(s) this should probably get:
>   Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")
> 
> In my testing this indeed fixes mSBC audio with both a Belkin (Broadcom
> BCM20702A, 050d:065a) and an Intel Bluetooth (8087:0a2b) adapters.
> 
>   Tested-By: Sjoerd Simons <sjoerd@collabora.com>

Tested on Intel AX200 Bluetooth (8087:0029):

Tested-by: Sebastian Reichel <sre@kernel.org>

The patch has been merged to Linus' tree today and I think it should
be applied to the 5.10 tree, which is used by Debian. This patch is
required to use BT headset with bidirectional-audio in acceptable
quality (That also requires proper userspace software, e.g. pipewire
0.3.22, which Sjoerd uploaded to Debian experimental).

Patch applies cleanly on 5.10.

Thanks,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-02-21 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  1:20 Trent Piepho
2020-12-10  1:47 ` bluez.test.bot
2020-12-18 21:23 ` [PATCH] " Marcel Holtmann
2021-02-06 15:56   ` Sjoerd Simons
2021-02-21 20:35     ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210221203557.wcmukv77sng25bql@earth.universe \
    --to=sre@kernel.org \
    --cc=amit.k.bag@intel.com \
    --cc=chethan.tumkur.narayan@intel.com \
    --cc=hildawu@realtek.com \
    --cc=hychao@chromium.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel@collabora.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=sathish.narasimman@intel.com \
    --cc=sjoerd@collabora.com \
    --cc=stable@vger.kernel.org \
    --cc=tpiepho@gmail.com \
    --subject='Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.