From: "Darrick J. Wong" <djwong@kernel.org>
To: Bastian Germann <bastiangermann@fishpost.de>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, Dimitri John Ledkov <xnox@ubuntu.com>
Subject: Re: [PATCH 1/4] debian: Drop trying to create upstream distribution
Date: Mon, 22 Feb 2021 19:07:11 -0800 [thread overview]
Message-ID: <20210223030711.GG7272@magnolia> (raw)
In-Reply-To: <20210221040129.GK4662@dread.disaster.area>
On Sun, Feb 21, 2021 at 03:01:29PM +1100, Dave Chinner wrote:
> On Sat, Feb 20, 2021 at 01:16:06PM +0100, Bastian Germann wrote:
> > This is a change introduced in 4.3.0+nmu1ubuntu1.
>
> Why? When the change was made is not important, explaining why the
> change needs to be made is what should be in the commit message.
> i.e. Tell us why this isn't needed any more...
Yes, this is vital information to have in the commit message.
I'm guessing it has something to do with the fact that 'make dist' tries
to create source tarballs, which is a strange thing to do during the
binary build, and in any case it ultimately fails because tarball
generation now requires .gitcensus, which is cleaned out and then
requires git to regeneration, which you can't do when you're building
from a source tarball?
<shrug> Hm?
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-02-23 3:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 12:16 [PATCH 0/4] debian: Integrate Debian/Ubuntu changes Bastian Germann
2021-02-20 12:16 ` [PATCH 1/4] debian: Drop trying to create upstream distribution Bastian Germann
2021-02-21 4:01 ` Dave Chinner
2021-02-23 3:07 ` Darrick J. Wong [this message]
2021-02-20 12:16 ` [PATCH 2/4] debian: Enable CET on amd64 Bastian Germann
2021-02-21 3:59 ` Dave Chinner
2021-02-21 4:02 ` NACK " Dimitri John Ledkov
2021-02-21 4:28 ` Dave Chinner
2021-02-21 4:32 ` Dimitri John Ledkov
2021-02-21 21:37 ` Dave Chinner
2021-02-20 12:16 ` [PATCH 3/4] debian: Regenerate config.guess using debhelper Bastian Germann
2021-02-21 4:11 ` Dave Chinner
2021-02-21 7:16 ` Steve Langasek
2021-02-21 22:04 ` Dave Chinner
2021-02-22 0:16 ` Steve Langasek
2021-02-22 2:44 ` Dave Chinner
2021-02-22 19:23 ` Eric Sandeen
2021-02-23 20:51 ` Dave Chinner
2021-02-20 12:16 ` [PATCH 4/4] debian: Build-depend on libinih-dev with udeb package Bastian Germann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223030711.GG7272@magnolia \
--to=djwong@kernel.org \
--cc=bastiangermann@fishpost.de \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xnox@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.