* [PATCH] rtw88: remove unnecessary variable
@ 2021-02-23 7:54 samirweng1979
2021-03-15 8:23 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: samirweng1979 @ 2021-02-23 7:54 UTC (permalink / raw)
To: tony0620emma, kvalo, davem, kuba
Cc: linux-wireless, netdev, inux-kernel, wengjianfeng
From: wengjianfeng <wengjianfeng@yulong.com>
The variable ret is defined at the beginning and initialized
to 0 until the function returns ret, and the variable ret is
not reassigned.Therefore, we do not need to define the variable
ret, just return 0 directly at the end of the function.
Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
---
drivers/net/wireless/realtek/rtw88/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index e6989c0..4c7e3e4 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1393,7 +1393,6 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
struct rtw_chip_info *chip = rtwdev->chip;
struct rtw_hal *hal = &rtwdev->hal;
struct rtw_efuse *efuse = &rtwdev->efuse;
- int ret = 0;
switch (rtw_hci_type(rtwdev)) {
case RTW_HCI_TYPE_PCIE:
@@ -1431,7 +1430,7 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
hal->bfee_sts_cap = 3;
- return ret;
+ return 0;
}
static int rtw_chip_efuse_enable(struct rtw_dev *rtwdev)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtw88: remove unnecessary variable
2021-02-23 7:54 [PATCH] rtw88: remove unnecessary variable samirweng1979
@ 2021-03-15 8:23 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-03-15 8:23 UTC (permalink / raw)
To: samirweng1979
Cc: tony0620emma, davem, kuba, linux-wireless, netdev, inux-kernel,
wengjianfeng
samirweng1979 <samirweng1979@163.com> wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> The variable ret is defined at the beginning and initialized
> to 0 until the function returns ret, and the variable ret is
> not reassigned.Therefore, we do not need to define the variable
> ret, just return 0 directly at the end of the function.
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
Patch applied to wireless-drivers-next.git, thanks.
4a7ea94377c9 rtw88: remove unnecessary variable
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210223075438.13676-1-samirweng1979@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-15 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 7:54 [PATCH] rtw88: remove unnecessary variable samirweng1979
2021-03-15 8:23 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.