Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data

From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Alexander Lobakin <alobakin@pm.me>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Sami Tolvanen <samitolvanen@google.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	Pei Huang <huangpei@loongson.cn>,
	Kees Cook <keescook@chromium.org>,
	Fangrui Song <maskray@google.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Corey Minyard <cminyard@mvista.com>,
	kernel test robot <lkp@intel.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
Date: Tue, 23 Feb 2021 13:21:44 +0100	[thread overview]
Message-ID: <20210223122144.GA7765@alpha.franken.de> (raw)
In-Reply-To: <20210223113600.7009-2-alobakin@pm.me>

On Tue, Feb 23, 2021 at 11:36:41AM +0000, Alexander Lobakin wrote:
> > LKP caught another bunch of orphaned instrumentation symbols [0]:
> >
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/main.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/main.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/do_mounts.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/do_mounts.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/initramfs.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/initramfs.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/calibrate.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/calibrate.o' being placed in section `.data.$LPBX0'
> >
> > [...]
> >
> > Soften the wildcard to .data.$L* to grab these ones into .data too.
> >
> > [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > ---
> >  include/asm-generic/vmlinux.lds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi Thomas,
> 
> This applies on top of mips-next or Linus' tree, so you may need to
> rebase mips-fixes before taking it.
> It's not for mips-next as it should go into this cycle as a [hot]fix.
> I haven't added any "Fixes:" tag since these warnings is a result
> of merging several sets and of certain build configurations that
> almost couldn't be tested separately.

no worries, mips-fixes is defunct during merge windows. I'll send another
pull request to Linus and will add this patch to it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]