All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Cohen <elic@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: <jasowang@redhat.com>, <linux-kernel@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<netdev@vger.kernel.org>, <si-wei.liu@oracle.com>
Subject: Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data
Date: Tue, 23 Feb 2021 14:43:17 +0200	[thread overview]
Message-ID: <20210223124316.GA171074@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20210223073225-mutt-send-email-mst@kernel.org>

On Tue, Feb 23, 2021 at 07:32:49AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 16, 2021 at 07:50:21AM +0200, Eli Cohen wrote:
> > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well
> > in mlx5v_remove().
> > 
> > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> 
> Sorry which tree this is for? Couldn't apply.
> 

Drop it. The patch that adds support for management bus implicitly
addresses the issue.

> > ---
> >  drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 6b0a42183622..4103d3b64a2a 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -2036,9 +2036,9 @@ static int mlx5v_probe(struct auxiliary_device *adev,
> >  
> >  static void mlx5v_remove(struct auxiliary_device *adev)
> >  {
> > -	struct mlx5_vdpa_dev *mvdev = dev_get_drvdata(&adev->dev);
> > +	struct mlx5_vdpa_net *ndev = dev_get_drvdata(&adev->dev);
> >  
> > -	vdpa_unregister_device(&mvdev->vdev);
> > +	vdpa_unregister_device(&ndev->mvdev.vdev);
> >  }
> >  
> >  static const struct auxiliary_device_id mlx5v_id_table[] = {
> > -- 
> > 2.29.2
> 

      reply	other threads:[~2021-02-23 12:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  5:50 [PATCH] vdpa/mlx5: Extract correct pointer from driver data Eli Cohen
2021-02-16  5:50 ` Eli Cohen
2021-02-16  6:35   ` Leon Romanovsky
2021-02-16  6:35     ` Leon Romanovsky
2021-02-16  6:42     ` Eli Cohen
2021-02-16  7:37       ` Leon Romanovsky
2021-02-16  7:37         ` Leon Romanovsky
2021-02-16 12:45         ` Eli Cohen
2021-02-16 13:17           ` Leon Romanovsky
2021-02-16 13:17             ` Leon Romanovsky
2021-02-23 12:32 ` Michael S. Tsirkin
2021-02-23 12:32   ` Michael S. Tsirkin
2021-02-23 12:43   ` Eli Cohen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223124316.GA171074@mtl-vdi-166.wap.labs.mlnx \
    --to=elic@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.