From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6FCC433E0 for ; Wed, 24 Feb 2021 00:56:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CE4764DA1 for ; Wed, 24 Feb 2021 00:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbhBXAzP (ORCPT ); Tue, 23 Feb 2021 19:55:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:57310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234660AbhBXAFk (ORCPT ); Tue, 23 Feb 2021 19:05:40 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C1D864DDC; Tue, 23 Feb 2021 23:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614124139; bh=/R0PvoIoUIWKETbltHn0Uho57C8iK6aTehVpfmDuRc8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n9qHuQJpSKkAo79u8yNzyLd+Olraemtbs5Gvm1s18RjmvsIRPjQxFcOypSJWcKwtl QtGuDXSwPN3JaMolaHdF9mLJa3NGiHhfTPgIrP4CZSj9TdKJXN+QewOvnncCeegiQp 7f5O0lFGKK0wN8c3kiLI0nhRVwFhRSFVaqjEUs3NOv6cxLmnM80SKkXJNs+LTQwfzj refJvVCeZ2bm3FKhNvF3QMmpeFEIC5oe4UQiK1YL1NE0B0QMYuvZ6JKc/IPnsm+Jd0 YaU1nrAQonPF8nVEY/zRgXi1O4O209OtGfEIPNUT5m7TT462Js95G5sBGI+3HlLBqG qW4d2HHxDLwPA== Date: Tue, 23 Feb 2021 15:48:55 -0800 From: Jakub Kicinski To: syzbot , alex.aring@gmail.com Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, stefan@datenfreihafen.org, syzkaller-bugs@googlegroups.com Subject: Re: UBSAN: shift-out-of-bounds in nl802154_new_interface Message-ID: <20210223154855.669413bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <000000000000e37c9805bbe843c1@google.com> References: <000000000000e37c9805bbe843c1@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex, there seems to be a few more syzbot reports for nl802154 beyond what you posted fixes for. Are you looking at these? On Mon, 22 Feb 2021 00:05:29 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 3af409ca net: enetc: fix destroyed phylink dereference dur.. > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=139da604d00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=8cb23303ddb9411f > dashboard link: https://syzkaller.appspot.com/bug?extid=7bf7b22759195c9a21e9 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=108c7e04d00000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1177c324d00000 > > Bisection is inconclusive: the issue happens on the oldest tested release. > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11a6e7d2d00000 > final oops: https://syzkaller.appspot.com/x/report.txt?x=13a6e7d2d00000 > console output: https://syzkaller.appspot.com/x/log.txt?x=15a6e7d2d00000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+7bf7b22759195c9a21e9@syzkaller.appspotmail.com > > ================================================================================ > UBSAN: shift-out-of-bounds in net/ieee802154/nl802154.c:914:44 > shift exponent -1627389953 is negative > CPU: 0 PID: 8454 Comm: syz-executor539 Not tainted 5.11.0-rc7-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:79 [inline] > dump_stack+0x107/0x163 lib/dump_stack.c:120 > ubsan_epilogue+0xb/0x5a lib/ubsan.c:148 > __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:395 > nl802154_new_interface.cold+0x19/0x1e net/ieee802154/nl802154.c:914 > genl_family_rcv_msg_doit+0x228/0x320 net/netlink/genetlink.c:739 > genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] > genl_rcv_msg+0x328/0x580 net/netlink/genetlink.c:800 > netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494 > genl_rcv+0x24/0x40 net/netlink/genetlink.c:811 > netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline] > netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330 > netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919 > sock_sendmsg_nosec net/socket.c:652 [inline] > sock_sendmsg+0xcf/0x120 net/socket.c:672 > ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345 > ___sys_sendmsg+0xf3/0x170 net/socket.c:2399 > __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432 > do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > RIP: 0033:0x43fa19 > Code: 28 c3 e8 5a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007fffda15b8b8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e > RAX: ffffffffffffffda RBX: 00000000004004a0 RCX: 000000000043fa19 > RDX: 0000000000000000 RSI: 0000000020000ac0 RDI: 0000000000000003 > RBP: 0000000000403480 R08: 0000000000000001 R09: 00000000004004a0 > R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000403510 > R13: 0000000000000000 R14: 00000000004ad018 R15: 00000000004004a0 > ================================================================================ > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > syzbot can test patches for this issue, for details see: > https://goo.gl/tpsmEJ#testing-patches