From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DD5C4332D for ; Wed, 24 Feb 2021 08:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CD2464D9F for ; Wed, 24 Feb 2021 08:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbhBXIMF (ORCPT ); Wed, 24 Feb 2021 03:12:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233900AbhBXILj (ORCPT ); Wed, 24 Feb 2021 03:11:39 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2B2C061786 for ; Wed, 24 Feb 2021 00:10:58 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id u4so1381773ljh.6 for ; Wed, 24 Feb 2021 00:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iaNQ0/x4wJABaIxpOlTlMzY4E0tMtNEPzTAE22Eqw1c=; b=RIrvGMvDbAEOIa9mCIYpti7ebILOp4DFAIBw8a7xY0r2+jv2Nim+K2cH9KtYBOa6bz 0gyHVWEyffWKl5HgNzFzEpzX518d3ZEU+J21zi7tFcJPUG8DeK9rH0NoSKYX320r1gHC jJnSyJ2l7J+zdQWTGzGYtRzFLMT1ClFdzMTp3+odi8eSTweXJX/vKHoBuwmqdvZeiLF7 KTUAMx3XksO9XCnB7P6N9cUEYOeS59DKD2StqaCdmotcspuhL7KqU6o2a8ra8L8qxBOn NKgS7n0e7EorYloxyd1rtvsvaiJnTR5+gYGS/1jK0H3dqSvQsUdoF0KWMNW2sQhlLUMS SpJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iaNQ0/x4wJABaIxpOlTlMzY4E0tMtNEPzTAE22Eqw1c=; b=RonaNyZkLrpZQs558Z5YXOz+voZT53feqtKt8VyAeartFPnVi45VR5ThaD80PG+jMY Z2cPvCmoE9qABKDD9z61oGbD1410D2D21J/Dr5a9vbO1ieOajWqqlL/t8K49wgIbc3zk QflF3O7twkI1m9rj9uUQEoMB8GwhQ6IrEm6LUHo11wq6bbrbLtq/qOVUCtW/qQNhIvdy 4VLN1R6RqyB2YDKpCmX/W2iYaCsVzk3oyhpoiMTsXRpJ5NtWTctrUuGZ6DqNhyvtgYi8 Ig+rCdZLNWmz+Equk1DKS2NYrTiF6vg3UZ9L/P1cmTx/7fLVyZWA9ORXcHSiU5Z5ZcdC SCYg== X-Gm-Message-State: AOAM530WfLvPVDYfRKfdK8dspFiSiS1c/4fFlhqVCqOEr4nYAjc76rJs zZ5G4lV923UO458rCutXmRqErQ== X-Google-Smtp-Source: ABdhPJxe41qfIAQ3R0LAzRwzVqwdgecZz2yhwQIK1ccJyvmIyUo934mlNbW08qNB94n5jqhlFgnLWw== X-Received: by 2002:a2e:5412:: with SMTP id i18mr9138650ljb.186.1614154257274; Wed, 24 Feb 2021 00:10:57 -0800 (PST) Received: from jade (h-249-223.A175.priv.bahnhof.se. [98.128.249.223]) by smtp.gmail.com with ESMTPSA id r28sm276804ljd.107.2021.02.24.00.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 00:10:56 -0800 (PST) Date: Wed, 24 Feb 2021 09:10:54 +0100 From: Jens Wiklander To: Steven Rostedt Cc: Jisheng Zhang , Linux Kernel Mailing List , op-tee@lists.trustedfirmware.org, Linux ARM Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210224081054.GA2653493@jade> References: <20210210144409.36ecdaed@xhacker.debian> <20210223184026.22c86356@xhacker.debian> <20210223131124.GA2303918@jade> <20210223091936.5b390f35@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210223091936.5b390f35@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 09:19:36AM -0500, Steven Rostedt wrote: > On Tue, 23 Feb 2021 14:11:24 +0100 > Jens Wiklander wrote: > > > I used the -strict option. > > > > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > #44: > > new file mode 100644 > > The above is just asking for someone to take maintainership of the new file. > > > > > CHECK: Alignment should match open parenthesis > > #68: FILE: drivers/tee/optee/optee_trace.h:20: > > +TRACE_EVENT(optee_invoke_fn_begin, > > + TP_PROTO(struct optee_rpc_param *param), > > > > CHECK: Lines should not end with a '(' > > #71: FILE: drivers/tee/optee/optee_trace.h:23: > > + TP_STRUCT__entry( > > > > CHECK: Lines should not end with a '(' > > #76: FILE: drivers/tee/optee/optee_trace.h:28: > > + TP_fast_assign( > > > > CHECK: Alignment should match open parenthesis > > #89: FILE: drivers/tee/optee/optee_trace.h:41: > > +TRACE_EVENT(optee_invoke_fn_end, > > + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), > > > > CHECK: Lines should not end with a '(' > > #92: FILE: drivers/tee/optee/optee_trace.h:44: > > + TP_STRUCT__entry( > > > > CHECK: Lines should not end with a '(' > > #97: FILE: drivers/tee/optee/optee_trace.h:49: > > + TP_fast_assign( > > The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles > over it. I usually recommend that people ignore the checkpatch warnings on > TRACE_EVENT() macros. Makes sense. I'll pick this up as it is. Thanks, Jens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FA1C433E0 for ; Wed, 24 Feb 2021 08:12:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DB7364D9F for ; Wed, 24 Feb 2021 08:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DB7364D9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=crPNjsOmrEL47hi00P9xeAhYtEemDD3xtaG4wdIvipU=; b=c0Qo0W/rVRf4TG8I1CZNB8mX1 UBQW+MwzkKZ5b1ZTPW6Olr5zv/L1axwqW15k4v6xsWr35OX5OsNgbzlr2cr6I09f8I3TfmE2/g4TP ivswFuLW+ngMJR7zvvgin8boQmfMcO31AI2QMbJcFflKEwf6ah5K4PVl4E0Upf+vViUJA2PJ1+byI IdNRnNWm2ouIoayCmTJoK9qDepx8FNoTRT/Fl6PxiiARanDHMrbFNO0Wa7DpOmA0wwcKNvbIE/sDS MUnb3k1WIhCz6w36OPX3wp+qMb36B7Z75/Uak8h6XxumPMkpBs7EBjUjTVSKl82aTUYY2ymHIxQfg oW52R01ew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEpGB-0003C3-RQ; Wed, 24 Feb 2021 08:11:03 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEpG8-0003B7-Ey for linux-arm-kernel@lists.infradead.org; Wed, 24 Feb 2021 08:11:02 +0000 Received: by mail-lj1-x231.google.com with SMTP id c8so1342932ljd.12 for ; Wed, 24 Feb 2021 00:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iaNQ0/x4wJABaIxpOlTlMzY4E0tMtNEPzTAE22Eqw1c=; b=RIrvGMvDbAEOIa9mCIYpti7ebILOp4DFAIBw8a7xY0r2+jv2Nim+K2cH9KtYBOa6bz 0gyHVWEyffWKl5HgNzFzEpzX518d3ZEU+J21zi7tFcJPUG8DeK9rH0NoSKYX320r1gHC jJnSyJ2l7J+zdQWTGzGYtRzFLMT1ClFdzMTp3+odi8eSTweXJX/vKHoBuwmqdvZeiLF7 KTUAMx3XksO9XCnB7P6N9cUEYOeS59DKD2StqaCdmotcspuhL7KqU6o2a8ra8L8qxBOn NKgS7n0e7EorYloxyd1rtvsvaiJnTR5+gYGS/1jK0H3dqSvQsUdoF0KWMNW2sQhlLUMS SpJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iaNQ0/x4wJABaIxpOlTlMzY4E0tMtNEPzTAE22Eqw1c=; b=OLoB4J4m7fwbkqyoXV3qRLNLn6szRXLPTl/OYlhAIVsuI2Yc2GRNCRNZI2lCcyIP5Q 7l4ms9EKcgcK0hxWE8hu3ggXGfLg7d10Ove1fWY601hycmuimAHkoF6lIh6QvsbCGIjT Uscy5PljazX39JrhBkkbJNCIZn2IoyMEtGU5Zz7YQISf8TbW99tJye9eef0+J9IdPVFm RpViD4fcZA7adf7d08kG9Bx+PcXoNZUwtldfNd8xG25ZilNxFy6jDWjomPYxBMGmWWg1 zhTl8a5/whntZDcZMIKP9A2ZOdjQlJbYzMqqNFEIzaspodusvlL7hI+IeqTTcuIeeuRR 0NmQ== X-Gm-Message-State: AOAM5303LA0IrriQh0qDefKwR8A96BFrzFt+L6pAF1uxRNPXHKRiUMC5 2hoh6jd+jiIUf9OSc+pcOp+oqA== X-Google-Smtp-Source: ABdhPJxe41qfIAQ3R0LAzRwzVqwdgecZz2yhwQIK1ccJyvmIyUo934mlNbW08qNB94n5jqhlFgnLWw== X-Received: by 2002:a2e:5412:: with SMTP id i18mr9138650ljb.186.1614154257274; Wed, 24 Feb 2021 00:10:57 -0800 (PST) Received: from jade (h-249-223.A175.priv.bahnhof.se. [98.128.249.223]) by smtp.gmail.com with ESMTPSA id r28sm276804ljd.107.2021.02.24.00.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 00:10:56 -0800 (PST) Date: Wed, 24 Feb 2021 09:10:54 +0100 From: Jens Wiklander To: Steven Rostedt Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210224081054.GA2653493@jade> References: <20210210144409.36ecdaed@xhacker.debian> <20210223184026.22c86356@xhacker.debian> <20210223131124.GA2303918@jade> <20210223091936.5b390f35@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210223091936.5b390f35@gandalf.local.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_031100_827690_9B451EE8 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jisheng Zhang , op-tee@lists.trustedfirmware.org, Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 23, 2021 at 09:19:36AM -0500, Steven Rostedt wrote: > On Tue, 23 Feb 2021 14:11:24 +0100 > Jens Wiklander wrote: > > > I used the -strict option. > > > > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > #44: > > new file mode 100644 > > The above is just asking for someone to take maintainership of the new file. > > > > > CHECK: Alignment should match open parenthesis > > #68: FILE: drivers/tee/optee/optee_trace.h:20: > > +TRACE_EVENT(optee_invoke_fn_begin, > > + TP_PROTO(struct optee_rpc_param *param), > > > > CHECK: Lines should not end with a '(' > > #71: FILE: drivers/tee/optee/optee_trace.h:23: > > + TP_STRUCT__entry( > > > > CHECK: Lines should not end with a '(' > > #76: FILE: drivers/tee/optee/optee_trace.h:28: > > + TP_fast_assign( > > > > CHECK: Alignment should match open parenthesis > > #89: FILE: drivers/tee/optee/optee_trace.h:41: > > +TRACE_EVENT(optee_invoke_fn_end, > > + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), > > > > CHECK: Lines should not end with a '(' > > #92: FILE: drivers/tee/optee/optee_trace.h:44: > > + TP_STRUCT__entry( > > > > CHECK: Lines should not end with a '(' > > #97: FILE: drivers/tee/optee/optee_trace.h:49: > > + TP_fast_assign( > > The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles > over it. I usually recommend that people ignore the checkpatch warnings on > TRACE_EVENT() macros. Makes sense. I'll pick this up as it is. Thanks, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel