All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Sameeruddin Shaik <sameeruddin.shaik8@gmail.com>,
	Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [Bug 210643] libtracefs: Add ways to set the filtering of function tracing
Date: Wed, 24 Feb 2021 09:17:32 -0500	[thread overview]
Message-ID: <20210224091732.0d0466a3@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN7tsF8=o1RQJc2rMAdbrFgmFvZmKWK9avbCPCa42U_iDw@mail.gmail.com>

On Wed, 24 Feb 2021 09:39:49 +0200
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:

> > --- Comment #7 from Steven Rostedt (rostedt@goodmis.org) ---
> > After some discussions on the mailing lists, I found that it is important to
> > establish the requirements that I expect of this API. I'm doing it in the
> > bugzilla instead of the mailing list (but will also forward this to the
> > mailing list), as this is more about the feature request and not about the
> > development of it.
> >
> > The prototype should be:
> >
> >  int tracefs_function_filter(struct tracefs_instance *instance,
> >                              const char * const *filters,
> >                              const char *module,
> >                              boolean reset);  
> 
> I think there should be a complementary API for deleting the filters,
> may be something like
>   int tracefs_function_filter_remove(struct tracefs_instance *instance,
>                                                         const char *
> const *filters,
>                                                         const char *module)
> It should be able to remove the filters, configured by the first API
> with the same "filters, module" input parameters.

Yes, I was going to even mention this, but figured my requirements were
long enough ;-)


-- Steve

      parent reply	other threads:[~2021-02-24 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 17:01 Fw: [Bug 210643] libtracefs: Add ways to set the filtering of function tracing Steven Rostedt
2021-02-23 20:59 ` Steven Rostedt
2021-02-24  7:39 ` Fw: " Tzvetomir Stoyanov
2021-02-24  9:34   ` Sameeruddin Shaik
2021-02-24 14:19     ` Steven Rostedt
2021-02-24 14:17   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224091732.0d0466a3@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=sameeruddin.shaik8@gmail.com \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.