From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA02C433DB for ; Wed, 24 Feb 2021 09:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3412D64E7A for ; Wed, 24 Feb 2021 09:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234620AbhBXJ2T (ORCPT ); Wed, 24 Feb 2021 04:28:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234536AbhBXJ2P (ORCPT ); Wed, 24 Feb 2021 04:28:15 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4E04C06178A for ; Wed, 24 Feb 2021 01:27:34 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id z7so839494plk.7 for ; Wed, 24 Feb 2021 01:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9CHIGqRTR4CpVrwPax1Th8sgFV6l7EPgJLkKjNdxhIk=; b=xsTA71e4zW4V1lpQyWlmtLwY1axG6YSbNhcPe2bGmyO3GjI0QwMmhQU3a2Fm7blPzM zBwPVVS7fihzrB7QcRo+iLgJd8QjBiKkTfJ2cMTcar0mDnOOyWaJvKo8uYNRatn5gowz x5KGo9j79hTUywutzBUFuADUAJklwqwgr8nP4Ea8SoAxsLvMaeVY3wprsYfO+Y0JP6qz CEvEwQPzwqNjj66qm+6TTnd2B9VQh6aMG3YKI2TiZ1qJLlSwwYaYxpRcizl25a20hbPx mU0DxYpgbphfVXMOOawDQ9G73F8SGXHOU+BkFUs9Gs4Ij0B7/LnVkyzKOujKUGbrPZBQ fZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9CHIGqRTR4CpVrwPax1Th8sgFV6l7EPgJLkKjNdxhIk=; b=JHKKKKiwJtajPdQEtwQodvCBZgS1iWhQ5umX7WSeODqQ+T1NO+BUdWR3YkalDEKa2B aheEqQl8MvHD6S9J2iHQ2aY1uV3o//GK0fO/kOsRjiW9usqPs7/aHZGsmUNPfGkVmlR2 DKBwhouMu5Bu0t0wMTc4zj+xwLrvJ7WxHV4ozW3iW+eZ/Oi7S+KwF4mhzvsCyI50mZJc LT1aQ34fTb+8GiaaJYDgb6rkB9K2eFLF2crCX3NhDuAqGQOnAG7qV7XZGBMN1LH74yrN r3DNFi6Q+mv8CiIQbytitc1lMObnjiaX0MjLhMvoeCZaQv5Egx7+VLCXiC0GBW4N9tDw UgyQ== X-Gm-Message-State: AOAM532UeS/2lCikJ/+KhuLK1O71wY8YY1kInqjnX1A5XcSjFDreDpIg uSN8IeTRHhz//pVLWhWxTbvGbGqe1E/b X-Google-Smtp-Source: ABdhPJyQklV/tRNBeP6QeXncSIa5VmyhQnE5PJ3KwX7RX74+N32c1t1kXu2c7QocDTB/U3U54SSepg== X-Received: by 2002:a17:902:d4cd:b029:e4:1abc:37e3 with SMTP id o13-20020a170902d4cdb02900e41abc37e3mr6873973plg.29.1614158854279; Wed, 24 Feb 2021 01:27:34 -0800 (PST) Received: from work ([103.66.79.25]) by smtp.gmail.com with ESMTPSA id w2sm1879246pgh.54.2021.02.24.01.27.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Feb 2021 01:27:33 -0800 (PST) Date: Wed, 24 Feb 2021 14:57:29 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, carl.yin@quectel.com, naveen.kumar@quectel.com Subject: Re: [PATCH v3 0/3] Polling for MHI ready Message-ID: <20210224092729.GM27945@work> References: <1614138270-2374-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614138270-2374-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 23, 2021 at 07:44:27PM -0800, Bhaumik Bhatt wrote: > v3: > -Removed config changes that crept in in the first patch > > v2: > -Addressed review comments > -Introduce new patch for to use controller defined read_reg() for polling > -Add usage in RDDM download panic path as well > > Use polling instead of interrupt driven approach to wait for MHI ready state. > > In certain devices, it is likely that there is no incoming MHI > interrupt for a transition to MHI READY state. One such example > is the move from Pass Through to an SBL or AMSS execution > environment. In order to facilitate faster bootup times as there > is no need to wait until timeout_ms completes, MHI host can poll > every 25 milliseconds to check if device has entered MHI READY > until a maximum timeout of twice the timeout_ms is reached. > > This patch series has been tested on an arm64 device. > So this is a spinoff from "Execution environment updates from MHI"? Please mention it in the cover letter and which one is the latest. Thanks, Mani > Bhaumik Bhatt (3): > bus: mhi: core: Introduce internal register poll helper function > bus: mhi: core: Move to polling method to wait for MHI ready > bus: mhi: core: Use poll register read API for RDDM download > > drivers/bus/mhi/core/boot.c | 20 ++++++-------------- > drivers/bus/mhi/core/internal.h | 3 +++ > drivers/bus/mhi/core/main.c | 23 +++++++++++++++++++++++ > drivers/bus/mhi/core/pm.c | 31 ++++++++++++++----------------- > 4 files changed, 46 insertions(+), 31 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >