All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Delaunay <patrick.delaunay@foss.st.com>
To: u-boot@lists.denx.de
Subject: [RFC PATCH 0/2] env: sf: remove the static env_flash variable
Date: Wed, 24 Feb 2021 11:52:34 +0100	[thread overview]
Message-ID: <20210224105236.25663-1-patrick.delaunay@foss.st.com> (raw)


Proposal to cleanup the SPI device support in env/sf.c,
after the question of mail [1].

Release the SPI flash after each ENV request, so U-Boot can't have
conflict of other SPI user.

This serie can be applied on top on previous serie [2].

Drawback: possible performance issue as SPI device is probed/release
for each ENV access when several ENV opts are called.

[1] Mail "Question about env_flash variable in env/sf.c" Dec 17, 2020; 6:33pm
http://u-boot.10912.n7.nabble.com/Question-about-env-flash-variable-in-env-sf-c-tt435311.html

[2] env: sf: add support of command env erase
http://patchwork.ozlabs.org/project/uboot/list/?series=228696&state=*

Patrick



Patrick Delaunay (2):
  env: sf: add missing spi_flash_free
  env: sf: remove the static env_flash variable

 env/sf.c | 44 ++++++++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 20 deletions(-)

-- 
2.17.1

             reply	other threads:[~2021-02-24 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 10:52 Patrick Delaunay [this message]
2021-02-24 10:52 ` [RFC PATCH 1/2] env: sf: add missing spi_flash_free Patrick Delaunay
2021-04-18 12:45   ` Tom Rini
2021-02-24 10:52 ` [RFC PATCH 2/2] env: sf: remove the static env_flash variable Patrick Delaunay
2021-04-18 12:46   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224105236.25663-1-patrick.delaunay@foss.st.com \
    --to=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.