From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55346C43332 for ; Wed, 24 Feb 2021 14:32:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 240D064EF5 for ; Wed, 24 Feb 2021 14:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237263AbhBXObT (ORCPT ); Wed, 24 Feb 2021 09:31:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:59888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236149AbhBXNOB (ORCPT ); Wed, 24 Feb 2021 08:14:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1E46164FB7; Wed, 24 Feb 2021 12:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614171366; bh=yj51SU//mNYpz9PNkp5VXs95l6Eadee+AHiu3hiECfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U/5/5mZa101dIgwCaO6OTactR7DJFdiaVkWiv3fl9IVxMG01Md9kAl5wjtsybRPTS 3v93tBmj9h8N6jlcc3pAOcX3p//0PrQO1iwxUOEHR1/VezUBQqnfQMz1nCMnyz3OvJ 8sBi2654huX/DgGO1LvRT1XpjMKt8z1QaMfMQPXG8BIyczuRMfkH08u7L/iZZlmP3L F086fxbfpqc8H78KwztSVzEcfoXLo2XVEC84NtQVNd8vNI1RrcJ8dtPSeZie+P8hoJ UL288Q49trYj4TcmjuEJTaWDIZRcYrKGKrrAe/mpVXIgihJH6KCxV3ufztblJwyjo3 krZDrJhOt1YFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Di Zhu , Jakub Kicinski , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/11] pktgen: fix misuse of BUG_ON() in pktgen_thread_worker() Date: Wed, 24 Feb 2021 07:55:53 -0500 Message-Id: <20210224125600.484437-5-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210224125600.484437-1-sashal@kernel.org> References: <20210224125600.484437-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Di Zhu [ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ] pktgen create threads for all online cpus and bond these threads to relevant cpu repecivtily. when this thread firstly be woken up, it will compare cpu currently running with the cpu specified at the time of creation and if the two cpus are not equal, BUG_ON() will take effect causing panic on the system. Notice that these threads could be migrated to other cpus before start running because of the cpu hotplug after these threads have created. so the BUG_ON() used here seems unreasonable and we can replace it with WARN_ON() to just printf a warning other than panic the system. Signed-off-by: Di Zhu Link: https://lore.kernel.org/r/20210125124229.19334-1-zhudi21@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 4ea957c1e7eee..5d0759e2102ed 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -3519,7 +3519,7 @@ static int pktgen_thread_worker(void *arg) struct pktgen_dev *pkt_dev = NULL; int cpu = t->cpu; - BUG_ON(smp_processor_id() != cpu); + WARN_ON(smp_processor_id() != cpu); init_waitqueue_head(&t->queue); complete(&t->start_done); -- 2.27.0