* [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep()
@ 2021-02-23 13:16 Chengguang Xu
2021-02-24 14:34 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2021-02-23 13:16 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, Chengguang Xu
commit 45dd052e67ad17c7a ("fs: handle FIEMAP_FLAG_SYNC in fiemap_prep")
has moved FIEMAP_FLAG_SYNC handling to fiemap_prep(), so don't have
to specify flags FIEMAP_FLAG_SYNC when calling fiemap_prep in
__generic_block_fiemap().
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 4e6cc0a7d69c..49355e689750 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -303,7 +303,7 @@ static int __generic_block_fiemap(struct inode *inode,
bool past_eof = false, whole_file = false;
int ret = 0;
- ret = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC);
+ ret = fiemap_prep(inode, fieinfo, start, &len, 0);
if (ret)
return ret;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep()
2021-02-23 13:16 [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep() Chengguang Xu
@ 2021-02-24 14:34 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2021-02-24 14:34 UTC (permalink / raw)
To: Chengguang Xu; +Cc: viro, linux-fsdevel
On Tue 23-02-21 21:16:32, Chengguang Xu wrote:
> commit 45dd052e67ad17c7a ("fs: handle FIEMAP_FLAG_SYNC in fiemap_prep")
> has moved FIEMAP_FLAG_SYNC handling to fiemap_prep(), so don't have
> to specify flags FIEMAP_FLAG_SYNC when calling fiemap_prep in
> __generic_block_fiemap().
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 4e6cc0a7d69c..49355e689750 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -303,7 +303,7 @@ static int __generic_block_fiemap(struct inode *inode,
> bool past_eof = false, whole_file = false;
> int ret = 0;
>
> - ret = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC);
> + ret = fiemap_prep(inode, fieinfo, start, &len, 0);
> if (ret)
> return ret;
>
> --
> 2.27.0
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-24 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 13:16 [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep() Chengguang Xu
2021-02-24 14:34 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.