From: Igor Mammedov <imammedo@redhat.com>
To: isaku.yamahata@gmail.com
Cc: isaku.yamahata@intel.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH v5 00/10] ACPI related fixes to comform the spec better
Date: Wed, 24 Feb 2021 17:08:35 +0100 [thread overview]
Message-ID: <20210224170835.738c92ec@redhat.com> (raw)
In-Reply-To: <cover.1613615732.git.isaku.yamahata@intel.com>
On Wed, 17 Feb 2021 21:51:08 -0800
isaku.yamahata@gmail.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>
> Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes
> by conforming to ACPI spec better.
Michael,
I finished with review,
to me series looks ready to be merged
> Changes from v4:
> - rebased to 1af5629673
> - move compat property from 3/10 to 4/10
> - use the end of the address for rage maximum of memory region
> - code simplification to generate _CRS
>
> Changes from v3:
> - rename compat property name to smm-compat and add it to ICH9-LPC and PIIX4_PM
> - MMCFG memory region to use dword memory region when possible
> - fix max base address of MMCFG memory region
> - add more test cases with smm-compat=on and/or piix4
>
> Changes from v2:
> - improved commit message
> - introduced compat property x-smm-compat-5
> - _CRS for MMCONFIG resource, read MMCONFIG info from qemu, generate resource
> instead of dynamically reading chipset configuration.
>
> Changes from v1:
> - fixed style issue with fixes to checkpatch.pl
> - fixed make check breakage
> - added ACPI table tests
> - update comment message to include acpi table diff
>
> Isaku Yamahata (9):
> checkpatch: don't emit warning on newly created acpi data files
> qtest: update tests/qtest/bios-tables-test-allowed-diff.h
> ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM
> acpi/core: always set SCI_EN when SMM isn't supported
> acpi: set fadt.smi_cmd to zero when SMM is not supported
> acpi: add test case for smm unsupported -machine smm=off
> hw/i386: declare ACPI mother board resource for MMCONFIG region
> acpi: add test case for -no-hpet
> qtest/acpi/bios-tables-test: update acpi tables
>
> Sean Christopherson (1):
> i386: acpi: Don't build HPET ACPI entry if HPET is disabled
>
> hw/acpi/core.c | 11 +++-
> hw/acpi/ich9.c | 2 +-
> hw/acpi/piix4.c | 5 +-
> hw/core/machine.c | 5 +-
> hw/i386/acpi-build.c | 72 +++++++++++++++++++--
> hw/isa/lpc_ich9.c | 1 +
> hw/isa/vt82c686.c | 2 +-
> include/hw/acpi/acpi.h | 4 +-
> include/hw/acpi/ich9.h | 1 +
> scripts/checkpatch.pl | 4 +-
> tests/data/acpi/pc/DSDT.nohpet | Bin 0 -> 4923 bytes
> tests/data/acpi/pc/FACP.nosmm | Bin 0 -> 116 bytes
> tests/data/acpi/q35/DSDT | Bin 7801 -> 7859 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9126 -> 9184 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 7819 -> 7877 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8265 -> 8323 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9455 -> 9513 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 7876 -> 7934 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9160 -> 9218 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 8932 -> 8990 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 0 -> 7717 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 7807 -> 7865 bytes
> tests/data/acpi/q35/DSDT.tis | Bin 8407 -> 8465 bytes
> tests/data/acpi/q35/FACP.nosmm | Bin 0 -> 244 bytes
> tests/qtest/bios-tables-test.c | 100 ++++++++++++++++++++++++++++++
> 25 files changed, 194 insertions(+), 13 deletions(-)
> create mode 100644 tests/data/acpi/pc/DSDT.nohpet
> create mode 100644 tests/data/acpi/pc/FACP.nosmm
> create mode 100644 tests/data/acpi/q35/DSDT.nohpet
> create mode 100644 tests/data/acpi/q35/FACP.nosmm
>
prev parent reply other threads:[~2021-02-24 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 5:51 [PATCH v5 00/10] ACPI related fixes to comform the spec better isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 01/10] checkpatch: don't emit warning on newly created acpi data files isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 02/10] qtest: update tests/qtest/bios-tables-test-allowed-diff.h isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 03/10] ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM isaku.yamahata
2021-02-23 14:22 ` Igor Mammedov
2021-02-18 5:51 ` [PATCH v5 04/10] acpi/core: always set SCI_EN when SMM isn't supported isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 05/10] acpi: set fadt.smi_cmd to zero when SMM is not supported isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 06/10] acpi: add test case for smm unsupported -machine smm=off isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region isaku.yamahata
2021-02-23 14:26 ` Igor Mammedov
2021-02-18 5:51 ` [PATCH v5 08/10] i386: acpi: Don't build HPET ACPI entry if HPET is disabled isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 09/10] acpi: add test case for -no-hpet isaku.yamahata
2021-02-18 5:51 ` [PATCH v5 10/10] qtest/acpi/bios-tables-test: update acpi tables isaku.yamahata
2021-02-24 16:08 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224170835.738c92ec@redhat.com \
--to=imammedo@redhat.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.