From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Oltean Date: Thu, 25 Feb 2021 00:25:52 +0200 Subject: [PATCH 4/4] net: dsa: remove master santiy check In-Reply-To: <20210224164042.21747-5-michael@walle.cc> References: <20210224164042.21747-1-michael@walle.cc> <20210224164042.21747-5-michael@walle.cc> Message-ID: <20210224222552.cpoiikhc6dbgninq@skbuf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 24, 2021 at 05:40:42PM +0100, Michael Walle wrote: > Because we probe the master ourselves (and fail if there is no master), > it is not possible that we don't have a master device. > > There is one catch though: device removal. We don't support that. It > wasn't supported neither before this patch. Because the master device > was only set in .pre_probe(), if a device was removed master_dev was a > dangling pointer and transmitting a frame cause a panic. I don't see a > good solution without having some sort of notify machanism when a > udevice is removed. > > Signed-off-by: Michael Walle > --- U-Boot DM maintainers might want to comment on this as well, but with the knowledge I have this seems good enough to me: Reviewed-by: Vladimir Oltean