From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F56C433DB for ; Wed, 24 Feb 2021 22:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B82C664F03 for ; Wed, 24 Feb 2021 22:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234912AbhBXWaU (ORCPT ); Wed, 24 Feb 2021 17:30:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234846AbhBXWaO (ORCPT ); Wed, 24 Feb 2021 17:30:14 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D8B3C06174A; Wed, 24 Feb 2021 14:29:34 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id s107so3790777otb.8; Wed, 24 Feb 2021 14:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u6XAvXUVnlDMggAEsXaHM4e8hEC4mF5s4JegHeSo1z4=; b=WXKmbDE438sr38D2CmGIsGEX4Geb9dTZqskZrMVRyU2zsH8cwKx74cPRXuOgXmiR8d 8PGR0VhKEGeP/oyqgHyMTEWKqGvNumu5SrC6Fw81zm3356flV7AhLkrrSHLiR42VWsYQ SFf5x3AO6UodLZ+mOW0mT+fny5pAh3ixBP1ZAcRvq83wf64eqkR5BbVrSKcE6pUnVn1V zWJh+SRYExHV/t73tRL0SEr5xz9J7gykl8C+7fRWqXCYT4b1AUZ5UB61zE20WkowXWAb NY4DQOAnMKOMZdrrWgFgx5z7qMCuYi52PYv9ODoKdzsmDg8tgMDDSB6zqQ2B2bh7Dlnb G1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=u6XAvXUVnlDMggAEsXaHM4e8hEC4mF5s4JegHeSo1z4=; b=HEpPG9z680TX0ADY7RxknQpCHQezuxzKWhBKlPcHhl1zK2wDw3ACuva16jojXjvD6q cy+R7b5jMi03f8tHyhg/qzRBD0Mxcc6jsqGu9HGZPXbHJVTKqeKXIm1HzmDP6Bg0XJx3 vndnxRqTDL/bTOeUs08Vcb0x+PnRGiIH8LU5ZhK3qNHzeFUyH5gbPRLbRJHruG0oZEDG lBlg4xnej65eRPhJOPAM7LGAvDwtplbrPxe3He/Rya3HYLP/VkrbrvoLDBkY1Nt0ytL8 0ojTpo5zAJZ1u1YhQhrh56Ea71Vtv+4UfmEoyGsyXQWiKGVv9YQP54xfRYY6+TQLcAeF Ek/w== X-Gm-Message-State: AOAM531B3UJUDJKMb3u5ObgLEZ6fmJLq1rR0YqZYxF9vi+db1fLF9qQ4 O2H3RpkSNgXQ5fI/Dze2Nnk= X-Google-Smtp-Source: ABdhPJy2cu+9ylE3pPDrNFQsj91Ax/vfHdFQuwgZeHJv5TM9WPR2gNSYiHYnpOkegPtmu+HWGG5leg== X-Received: by 2002:a05:6830:4c9:: with SMTP id s9mr14765343otd.133.1614205773544; Wed, 24 Feb 2021 14:29:33 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d13sm665063otf.52.2021.02.24.14.29.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Feb 2021 14:29:32 -0800 (PST) Sender: Guenter Roeck Date: Wed, 24 Feb 2021 14:29:31 -0800 From: Guenter Roeck To: Sami Tolvanen Cc: Kees Cook , Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , PCI , linux-parisc@vger.kernel.org, Helge Deller Subject: Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) Message-ID: <20210224222931.GB74404@roeck-us.net> References: <20201211184633.3213045-1-samitolvanen@google.com> <20201211184633.3213045-2-samitolvanen@google.com> <20210224201723.GA69309@roeck-us.net> <202102241238.93BC4DCF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Feb 24, 2021 at 12:54:15PM -0800, Sami Tolvanen wrote: > On Wed, Feb 24, 2021 at 12:38 PM Kees Cook wrote: > > > > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > > Move function tracer options to Kconfig to make it easier to add > > > > new methods for generating __mcount_loc, and to make the options > > > > available also when building kernel modules. > > > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > > therefore, work even if the .config was generated in a different > > > > environment. > > > > > > > > Signed-off-by: Sami Tolvanen > > > > Acked-by: Steven Rostedt (VMware) > > > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > > > Error log: > > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > > depends on it. > > > > Ew. Any idea why this didn't show up while it was in linux-next? > > Does anyone build parisc allmodconfig from -next? > https://kerneltests.org/builders/next-parisc-next Guenter > parisc seems to always use -fpatchable-function-entry with dynamic > ftrace, so we just need to select > FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to stop it from defaulting > to recordmcount: > > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index ecef9aff9d72..9ee806f68123 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -60,6 +60,7 @@ config PARISC > select HAVE_KPROBES > select HAVE_KRETPROBES > select HAVE_DYNAMIC_FTRACE if > $(cc-option,-fpatchable-function-entry=1,1) > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE > select HAVE_KPROBES_ON_FTRACE > select HAVE_DYNAMIC_FTRACE_WITH_REGS > > I'll send a proper patch shortly. > > Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE8BC433DB for ; Wed, 24 Feb 2021 22:30:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 932DC64EDD for ; Wed, 24 Feb 2021 22:30:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 932DC64EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=omAmfND20aEZKkkDTjhR5Oj/NItWFbcI99h+LrEhAI8=; b=1k3g1HXcxPIhDPJCSvRfK3THY fotT5tBIvf0yMmytwruk2a+pQqhAIk4Shf6sFsyoEozX9te98z44nXh1/0CWDg2fdvjIbT3gRqw97 mB4QmbKyREJTFAKQZwdDYdRjjcX1mOXvKc0OhottKr+DAvz9jPLeO5NrcptsN/WqvR8UdyBOIZtnk JEY0mETeoeaEpM+1y2nxElOvQ4E8gs4cCiSP4EzcB5fNrXYvsiFcTUh44FZ6VgpD4OPEnochUMIRR f3ulW6uhR5VgCLzTC/Xeua5c8WrpjZWieSGVQtAGPvUmaAO0kE37JzpOEc0nUJJiGc93r874emP2A I3olZZWFA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lF2f5-00048i-0P; Wed, 24 Feb 2021 22:29:39 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lF2f2-00047t-Ae for linux-arm-kernel@lists.infradead.org; Wed, 24 Feb 2021 22:29:37 +0000 Received: by mail-ot1-x329.google.com with SMTP id 105so3823899otd.3 for ; Wed, 24 Feb 2021 14:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u6XAvXUVnlDMggAEsXaHM4e8hEC4mF5s4JegHeSo1z4=; b=WXKmbDE438sr38D2CmGIsGEX4Geb9dTZqskZrMVRyU2zsH8cwKx74cPRXuOgXmiR8d 8PGR0VhKEGeP/oyqgHyMTEWKqGvNumu5SrC6Fw81zm3356flV7AhLkrrSHLiR42VWsYQ SFf5x3AO6UodLZ+mOW0mT+fny5pAh3ixBP1ZAcRvq83wf64eqkR5BbVrSKcE6pUnVn1V zWJh+SRYExHV/t73tRL0SEr5xz9J7gykl8C+7fRWqXCYT4b1AUZ5UB61zE20WkowXWAb NY4DQOAnMKOMZdrrWgFgx5z7qMCuYi52PYv9ODoKdzsmDg8tgMDDSB6zqQ2B2bh7Dlnb G1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=u6XAvXUVnlDMggAEsXaHM4e8hEC4mF5s4JegHeSo1z4=; b=MaXL4Q6ZaPzgxk0NPXmzRdEAL6u/FWlyGROi12fmIUN6U0If4PGnYPDbuSNrSL8cWk dIkFRDw630+xEm+6aHwISRtbzkjlQN67Ri996itH5WBd8tr9kS1SX6U4uQdwtSE3tnIB G68w+mkxMc2ofe/DbLGUnsxAQauWf5F4O5M0R5XqVEYie4hY7SUWriK/DDF6vEN/J1Kt 51ZohAq6rPKh0VG2LQm69PVNQhADAw9562z/yb9AsTATZkikAqxLkejHq6peiHlDVd5m EQDY+x/YaCGAPP3oRVcmcegbZ4+DDkGAI2+GEMyBlTNHbfS/QsLy+07VOV+S28H0x9HK 61Nw== X-Gm-Message-State: AOAM532dBpclZ6c+8XyRHy2coDEfgzvIa8rLYkDfhtB+aNqs3uuumZqQ TCg8YkhcsAmzH5aXS95IBxg= X-Google-Smtp-Source: ABdhPJy2cu+9ylE3pPDrNFQsj91Ax/vfHdFQuwgZeHJv5TM9WPR2gNSYiHYnpOkegPtmu+HWGG5leg== X-Received: by 2002:a05:6830:4c9:: with SMTP id s9mr14765343otd.133.1614205773544; Wed, 24 Feb 2021 14:29:33 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d13sm665063otf.52.2021.02.24.14.29.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Feb 2021 14:29:32 -0800 (PST) Date: Wed, 24 Feb 2021 14:29:31 -0800 From: Guenter Roeck To: Sami Tolvanen Subject: Re: [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) Message-ID: <20210224222931.GB74404@roeck-us.net> References: <20201211184633.3213045-1-samitolvanen@google.com> <20201211184633.3213045-2-samitolvanen@google.com> <20210224201723.GA69309@roeck-us.net> <202102241238.93BC4DCF@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_172936_399437_DFDDEB3F X-CRM114-Status: GOOD ( 29.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , PCI , linux-parisc@vger.kernel.org, Josh Poimboeuf , Will Deacon , Helge Deller , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 24, 2021 at 12:54:15PM -0800, Sami Tolvanen wrote: > On Wed, Feb 24, 2021 at 12:38 PM Kees Cook wrote: > > > > On Wed, Feb 24, 2021 at 12:17:23PM -0800, Guenter Roeck wrote: > > > On Fri, Dec 11, 2020 at 10:46:18AM -0800, Sami Tolvanen wrote: > > > > Move function tracer options to Kconfig to make it easier to add > > > > new methods for generating __mcount_loc, and to make the options > > > > available also when building kernel modules. > > > > > > > > Note that FTRACE_MCOUNT_USE_* options are updated on rebuild and > > > > therefore, work even if the .config was generated in a different > > > > environment. > > > > > > > > Signed-off-by: Sami Tolvanen > > > > Acked-by: Steven Rostedt (VMware) > > > > > > With this patch in place, parisc:allmodconfig no longer builds. > > > > > > Error log: > > > Arch parisc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at scripts/recordmcount.pl line 405. > > > make[2]: *** [scripts/mod/empty.o] Error 2 > > > > > > Due to this problem, CONFIG_FTRACE_MCOUNT_RECORD can no longer be > > > enabled in parisc builds. Since that is auto-selected by DYNAMIC_FTRACE, > > > DYNAMIC_FTRACE can no longer be enabled, and with it everything that > > > depends on it. > > > > Ew. Any idea why this didn't show up while it was in linux-next? > > Does anyone build parisc allmodconfig from -next? > https://kerneltests.org/builders/next-parisc-next Guenter > parisc seems to always use -fpatchable-function-entry with dynamic > ftrace, so we just need to select > FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to stop it from defaulting > to recordmcount: > > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index ecef9aff9d72..9ee806f68123 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -60,6 +60,7 @@ config PARISC > select HAVE_KPROBES > select HAVE_KRETPROBES > select HAVE_DYNAMIC_FTRACE if > $(cc-option,-fpatchable-function-entry=1,1) > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE > select HAVE_KPROBES_ON_FTRACE > select HAVE_DYNAMIC_FTRACE_WITH_REGS > > I'll send a proper patch shortly. > > Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel