Re: [RFC PATCH v2 net-next 17/17] net: bridge: offloaded ports are always promiscuous

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2680 bytes --]

Hi Vladimir,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/RX-filtering-in-DSA/20210224-195147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
config: openrisc-randconfig-p002-20210223 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/57f6434fb1b797f12dc1b614e68dba69054caee2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vladimir-Oltean/RX-filtering-in-DSA/20210224-195147
        git checkout 57f6434fb1b797f12dc1b614e68dba69054caee2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/bridge/br_if.c: In function 'br_port_clear_promisc':
>> net/bridge/br_if.c:120:7: error: 'struct net_bridge_port' has no member named 'offloaded'
     120 |      p->offloaded)
         |       ^~


vim +120 net/bridge/br_if.c

   106	
   107	static void br_port_clear_promisc(struct net_bridge_port *p)
   108	{
   109		int err;
   110	
   111		/* Check if the port is already non-promisc or if it doesn't
   112		 * support UNICAST filtering.  Without unicast filtering support
   113		 * we'll end up re-enabling promisc mode anyway, so just check for
   114		 * it here. Also, a switchdev offloading this port needs to be
   115		 * promiscuous by definition, so don't even attempt to get it out of
   116		 * promiscuous mode or sync unicast FDB entries to it, since that is
   117		 * pointless and not necessary.
   118		 */
   119		if (!br_promisc_port(p) || !(p->dev->priv_flags & IFF_UNICAST_FLT) ||
 > 120		    p->offloaded)
   121			return;
   122	
   123		/* Since we'll be clearing the promisc mode, program the port
   124		 * first so that we don't have interruption in traffic.
   125		 */
   126		err = br_fdb_sync_static(p->br, p);
   127		if (err)
   128			return;
   129	
   130		dev_set_promiscuity(p->dev, -1);
   131		p->flags &= ~BR_PROMISC;
   132	}
   133	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 22478 bytes --]