All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/elf_ops: Fix a typo
Date: Thu, 25 Feb 2021 22:39:11 +0100	[thread overview]
Message-ID: <20210225213911.5vnawz7nweuoatyk@steredhat> (raw)
In-Reply-To: <20210225181344.3623720-1-philmd@redhat.com>

On Thu, Feb 25, 2021 at 07:13:44PM +0100, Philippe Mathieu-Daudé wrote:
>g_mapped_file_new_from_fd()'s parameter is named 'writable'.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> include/hw/elf_ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
>index 8e8436831d2..304f266bf3b 100644
>--- a/include/hw/elf_ops.h
>+++ b/include/hw/elf_ops.h
>@@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>
>     /*
>      * Since we want to be able to modify the mapped buffer, we set the
>-     * 'writeble' parameter to 'true'. Modifications to the buffer are not
>+     * 'writable' parameter to 'true'. Modifications to the buffer are not

Oooops :-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>



  reply	other threads:[~2021-02-25 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 18:13 [PATCH] hw/elf_ops: Fix a typo Philippe Mathieu-Daudé
2021-02-25 21:39 ` Stefano Garzarella [this message]
2021-03-03  8:18 ` David Edmondson
2021-03-09 20:28 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225213911.5vnawz7nweuoatyk@steredhat \
    --to=sgarzare@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.