All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Bean Huo <huobean@gmail.com>,
	Daejun Park <daejun7.park@samsung.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	JinHwan Park <jh.i.park@samsung.com>,
	Javier Gonzalez <javier.gonz@samsung.com>,
	SEUNGUK SHIN <seunguk.shin@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	BoRam Shin <boram.shin@samsung.com>
Subject: RE: Re: [PATCH v24 1/4] scsi: ufs: Introduce HPB feature
Date: Fri, 26 Feb 2021 13:49:23 +0900	[thread overview]
Message-ID: <20210226044923epcms2p1fa387ff8d1eaac09a8cce146d63ea205@epcms2p1> (raw)
In-Reply-To: <50f8a0963e887542a467e690b6d406675279a4e5.camel@gmail.com>

> > 
> > +void ufshpb_init(struct ufs_hba *hba)
> > +{
> > +        struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> > +        int try;
> > +        int ret;
> > +
> > +        if (!ufshpb_is_allowed(hba))
> > +                return;
> > +
>  
> Here it is better to check "dev_info->hpb_enable", if HPB is not
> enabled from UFS device level,  doesn't need to create mempool and take
> other memory resource.

I will add checking dev_info->hpb_enable value.
if (!ufshpb_is_allowed(hba) || !dev_info->hpb_enable)

Thanks,
Daejun

> Bean
>  
>  
>  
>  
>  
>   

  parent reply	other threads:[~2021-02-26  4:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p6>
2021-02-24  4:53 ` [PATCH v24 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
     [not found]   ` <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p7>
2021-02-24  4:54     ` [PATCH v24 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-02-25 14:59       ` Bean Huo
     [not found]       ` <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p4>
2021-02-26  4:53         ` Daejun Park
2021-02-24  4:55     ` [PATCH v24 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
     [not found]   ` <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p2>
2021-02-24  4:54     ` [PATCH v24 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-02-25 14:38       ` Bean Huo
     [not found]       ` <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p1>
2021-02-26  4:49         ` Daejun Park [this message]
2021-02-24  4:55     ` [PATCH v24 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-02-24  9:52       ` Avri Altman
2021-02-24 10:24       ` Avri Altman
2021-02-24 11:52         ` Avri Altman
     [not found]         ` <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p5>
2021-02-25  3:25           ` Daejun Park
2021-02-25  3:26 ` Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226044923epcms2p1fa387ff8d1eaac09a8cce146d63ea205@epcms2p1 \
    --to=daejun7.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=javier.gonz@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=jh.i.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=seunguk.shin@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.