From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C23C433E0 for ; Fri, 26 Feb 2021 09:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B43964F3E for ; Fri, 26 Feb 2021 09:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbhBZJWi (ORCPT ); Fri, 26 Feb 2021 04:22:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbhBZJUc (ORCPT ); Fri, 26 Feb 2021 04:20:32 -0500 Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D698C06178A for ; Fri, 26 Feb 2021 01:17:41 -0800 (PST) Received: by mail-qk1-x749.google.com with SMTP id h126so6831905qkd.4 for ; Fri, 26 Feb 2021 01:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=Sbwg5mnD28MfpC+5A1wM48SOZxACByUsBU0/u8gNTKY=; b=pDKOOjv7DnHHQqrg/o+zEsKkWF6x5gJ8Fur6sxRl9VJeF+L2t+3lXAtN4UD3QfSEGf gNuU11Wvw8rCxdt+EtvkzV0n17p5vz/d2YcjCL/AJ+Wq2obyFyYTXnOQmxJoPP2Vfqjg egIrc2c6XpfhqnxV640YmCd8zBD/336iPLy2rZ/sgobFxh0J2C9KF4lJFihbfy5U41Z0 KXTFcssDgfbdmsGx08n3uKiG3a+GYRPOmiGO7rCb/QJ9JtlMgmnW4mH4b7olvP1gnS3e KZA231HlJ5VE7LiFn+VXX19WqPl501ql30DaMJFESUtP7G1mUtQPxdck5md0v29w6DPM 5Qhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Sbwg5mnD28MfpC+5A1wM48SOZxACByUsBU0/u8gNTKY=; b=ClvY0K+gwuvNXSwpwt3luAz7jTZiN0kio3kPVLDV9G75NZo2WQQs1rbtD9arlSxxnm nhIR/yFMWQcfnV+Eg0uJqpsDV+3ERDjOO82dqUDTfzxkj6VeHqPTar/aGgVFioQ4b/VO Cy0qzAc74LnuiRLL0LIM0VMND0+HHoxlzA0B7eSPqQo5XE3Eyypd5KpHN+RV8XLbbh6z cM4+KYI+9wdv+hVpWJ5miYu/6fIZ8yIwxnN59HPtr5inozP6BBncsXdktqx/T/VkizU+ yqSvIjCYL82N4Uv8YEvMOQYtfiYYwKsOJ3vsUHiIpuGzUqEs+pUC16KTKl4isZwSYYDK s4Xg== X-Gm-Message-State: AOAM533nk7JveaqBTgW4Iinq5Eem4HfISkr9nvEhIuv7BqGc+pLPVa5F RJfZ1k1zN4P6it27ump4k824sV2ocAU= X-Google-Smtp-Source: ABdhPJw49NwW1osDcsWfZjZWCmhBnG2VmrWEsp3yjpjWhKXeQaLf57JEP91v5nodzzC+al8WBoFwA4ENe74= Sender: "yuzhao via sendgmr" X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:69b6:2618:c96a:ceba]) (user=yuzhao job=sendgmr) by 2002:a0c:b998:: with SMTP id v24mr1673365qvf.4.1614331060711; Fri, 26 Feb 2021 01:17:40 -0800 (PST) Date: Fri, 26 Feb 2021 02:17:18 -0700 In-Reply-To: <20210226091718.2927291-1-yuzhao@google.com> Message-Id: <20210226091718.2927291-4-yuzhao@google.com> Mime-Version: 1.0 References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog Subject: [PATCH v2 3/3] mm: use PF_ONLY_HEAD for PG_active and PG_unevictable From: Yu Zhao To: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org Cc: guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com, Yu Zhao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All places but one test, set or clear PG_active and PG_unevictable on small or head pages. Use compound_head() explicitly for that singleton so the rest can rid of redundant compound_head(). bloat-o-meter result: add/remove: 0/0 grow/shrink: 3/38 up/down: 388/-4270 (-3882) Signed-off-by: Yu Zhao --- fs/proc/task_mmu.c | 3 ++- include/linux/page-flags.h | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 3cec6fbef725..c866c363bb41 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1712,6 +1712,7 @@ static void gather_stats(struct page *page, struct numa_maps *md, int pte_dirty, unsigned long nr_pages) { int count = page_mapcount(page); + struct page *head = compound_head(page); md->pages += nr_pages; if (pte_dirty || PageDirty(page)) @@ -1720,7 +1721,7 @@ static void gather_stats(struct page *page, struct numa_maps *md, int pte_dirty, if (PageSwapCache(page)) md->swapcache += nr_pages; - if (PageActive(page) || PageUnevictable(page)) + if (PageActive(head) || PageUnevictable(head)) md->active += nr_pages; if (PageWriteback(page)) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index c9626e54df8d..b7fe855a6ee9 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -335,8 +335,8 @@ PAGEFLAG(Dirty, dirty, PF_HEAD) TESTSCFLAG(Dirty, dirty, PF_HEAD) __CLEARPAGEFLAG(Dirty, dirty, PF_HEAD) PAGEFLAG(LRU, lru, PF_NO_TAIL) __CLEARPAGEFLAG(LRU, lru, PF_NO_TAIL) TESTCLEARFLAG(LRU, lru, PF_NO_TAIL) -PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) - TESTCLEARFLAG(Active, active, PF_HEAD) +PAGEFLAG(Active, active, PF_ONLY_HEAD) __CLEARPAGEFLAG(Active, active, PF_ONLY_HEAD) + TESTCLEARFLAG(Active, active, PF_ONLY_HEAD) PAGEFLAG(Workingset, workingset, PF_HEAD) TESTCLEARFLAG(Workingset, workingset, PF_HEAD) __PAGEFLAG(Slab, slab, PF_NO_TAIL) @@ -407,9 +407,9 @@ CLEARPAGEFLAG(SwapCache, swapcache, PF_NO_TAIL) PAGEFLAG_FALSE(SwapCache) #endif -PAGEFLAG(Unevictable, unevictable, PF_HEAD) - __CLEARPAGEFLAG(Unevictable, unevictable, PF_HEAD) - TESTCLEARFLAG(Unevictable, unevictable, PF_HEAD) +PAGEFLAG(Unevictable, unevictable, PF_ONLY_HEAD) + __CLEARPAGEFLAG(Unevictable, unevictable, PF_ONLY_HEAD) + TESTCLEARFLAG(Unevictable, unevictable, PF_ONLY_HEAD) #ifdef CONFIG_MMU PAGEFLAG(Mlocked, mlocked, PF_NO_TAIL) -- 2.30.1.766.gb4fecdf3b7-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67AFC433DB for ; Fri, 26 Feb 2021 09:17:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6521D64EE7 for ; Fri, 26 Feb 2021 09:17:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6521D64EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63F0C6B0074; Fri, 26 Feb 2021 04:17:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 619258D0002; Fri, 26 Feb 2021 04:17:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 494108D0001; Fri, 26 Feb 2021 04:17:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 2B9646B0074 for ; Fri, 26 Feb 2021 04:17:42 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DC40B18343F7E for ; Fri, 26 Feb 2021 09:17:41 +0000 (UTC) X-FDA: 77859866322.08.CE7A423 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) by imf22.hostedemail.com (Postfix) with ESMTP id DF1FCC0007D2 for ; Fri, 26 Feb 2021 09:17:37 +0000 (UTC) Received: by mail-qk1-f202.google.com with SMTP id t6so2672206qkt.14 for ; Fri, 26 Feb 2021 01:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=Sbwg5mnD28MfpC+5A1wM48SOZxACByUsBU0/u8gNTKY=; b=pDKOOjv7DnHHQqrg/o+zEsKkWF6x5gJ8Fur6sxRl9VJeF+L2t+3lXAtN4UD3QfSEGf gNuU11Wvw8rCxdt+EtvkzV0n17p5vz/d2YcjCL/AJ+Wq2obyFyYTXnOQmxJoPP2Vfqjg egIrc2c6XpfhqnxV640YmCd8zBD/336iPLy2rZ/sgobFxh0J2C9KF4lJFihbfy5U41Z0 KXTFcssDgfbdmsGx08n3uKiG3a+GYRPOmiGO7rCb/QJ9JtlMgmnW4mH4b7olvP1gnS3e KZA231HlJ5VE7LiFn+VXX19WqPl501ql30DaMJFESUtP7G1mUtQPxdck5md0v29w6DPM 5Qhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Sbwg5mnD28MfpC+5A1wM48SOZxACByUsBU0/u8gNTKY=; b=lPLxGR3P7Y2Pv2LgQYOU1HpLEphBch4ga55BjgaIDpU1ZGevOBGycOsufZy7CCuZjw OXngZM3wmUPHKhCUfBg2rsMAKaqXqPub5E/pZxOjcpx/mQfeyetZbRENssiKWa5+f/ZU uHQeLxJmBiSa7hYUBOUr/DcZBJ0nupobXbokPtMNE2rcuYg8xCvW+vBshISiuY73yqy1 m35h4nckS7L1dsWytXEd/PH7gf45AP8rwiv5Xd0CmrtY310sBoS3DKur3rFQF2xhkoGV /SVLBY32BN4e7X2erkxLxU3SgH3U2FlP9cbYtASjEy4aoiYr51VtxU5DIwYAApViPYRz 1+8Q== X-Gm-Message-State: AOAM531Mik3gD87bVuTTZSUYcm0OArk+pEu6fyUYAgVIY94V3JuFJoPw FvAe54anphVUQjQsCBISN7V8y245R88= X-Google-Smtp-Source: ABdhPJw49NwW1osDcsWfZjZWCmhBnG2VmrWEsp3yjpjWhKXeQaLf57JEP91v5nodzzC+al8WBoFwA4ENe74= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:69b6:2618:c96a:ceba]) (user=yuzhao job=sendgmr) by 2002:a0c:b998:: with SMTP id v24mr1673365qvf.4.1614331060711; Fri, 26 Feb 2021 01:17:40 -0800 (PST) Date: Fri, 26 Feb 2021 02:17:18 -0700 In-Reply-To: <20210226091718.2927291-1-yuzhao@google.com> Message-Id: <20210226091718.2927291-4-yuzhao@google.com> Mime-Version: 1.0 References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog Subject: [PATCH v2 3/3] mm: use PF_ONLY_HEAD for PG_active and PG_unevictable From: Yu Zhao To: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org Cc: guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com, Yu Zhao Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DF1FCC0007D2 X-Stat-Signature: hqzhfrquxqtmn3aairuryrjnpiuysn76 Received-SPF: none (flex--yuzhao.bounces.google.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from="<3tLw4YAYKCBkNJO6zD5DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yuzhao.bounces.google.com>"; helo=mail-qk1-f202.google.com; client-ip=209.85.222.202 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614331057-743996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All places but one test, set or clear PG_active and PG_unevictable on small or head pages. Use compound_head() explicitly for that singleton so the rest can rid of redundant compound_head(). bloat-o-meter result: add/remove: 0/0 grow/shrink: 3/38 up/down: 388/-4270 (-3882) Signed-off-by: Yu Zhao --- fs/proc/task_mmu.c | 3 ++- include/linux/page-flags.h | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 3cec6fbef725..c866c363bb41 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1712,6 +1712,7 @@ static void gather_stats(struct page *page, struct numa_maps *md, int pte_dirty, unsigned long nr_pages) { int count = page_mapcount(page); + struct page *head = compound_head(page); md->pages += nr_pages; if (pte_dirty || PageDirty(page)) @@ -1720,7 +1721,7 @@ static void gather_stats(struct page *page, struct numa_maps *md, int pte_dirty, if (PageSwapCache(page)) md->swapcache += nr_pages; - if (PageActive(page) || PageUnevictable(page)) + if (PageActive(head) || PageUnevictable(head)) md->active += nr_pages; if (PageWriteback(page)) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index c9626e54df8d..b7fe855a6ee9 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -335,8 +335,8 @@ PAGEFLAG(Dirty, dirty, PF_HEAD) TESTSCFLAG(Dirty, dirty, PF_HEAD) __CLEARPAGEFLAG(Dirty, dirty, PF_HEAD) PAGEFLAG(LRU, lru, PF_NO_TAIL) __CLEARPAGEFLAG(LRU, lru, PF_NO_TAIL) TESTCLEARFLAG(LRU, lru, PF_NO_TAIL) -PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) - TESTCLEARFLAG(Active, active, PF_HEAD) +PAGEFLAG(Active, active, PF_ONLY_HEAD) __CLEARPAGEFLAG(Active, active, PF_ONLY_HEAD) + TESTCLEARFLAG(Active, active, PF_ONLY_HEAD) PAGEFLAG(Workingset, workingset, PF_HEAD) TESTCLEARFLAG(Workingset, workingset, PF_HEAD) __PAGEFLAG(Slab, slab, PF_NO_TAIL) @@ -407,9 +407,9 @@ CLEARPAGEFLAG(SwapCache, swapcache, PF_NO_TAIL) PAGEFLAG_FALSE(SwapCache) #endif -PAGEFLAG(Unevictable, unevictable, PF_HEAD) - __CLEARPAGEFLAG(Unevictable, unevictable, PF_HEAD) - TESTCLEARFLAG(Unevictable, unevictable, PF_HEAD) +PAGEFLAG(Unevictable, unevictable, PF_ONLY_HEAD) + __CLEARPAGEFLAG(Unevictable, unevictable, PF_ONLY_HEAD) + TESTCLEARFLAG(Unevictable, unevictable, PF_ONLY_HEAD) #ifdef CONFIG_MMU PAGEFLAG(Mlocked, mlocked, PF_NO_TAIL) -- 2.30.1.766.gb4fecdf3b7-goog