From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree
Date: Fri, 26 Feb 2021 12:31:44 +0000 [thread overview]
Message-ID: <20210226123144.cwhjberqeyjctc6w@bigthink> (raw)
In-Reply-To: <7254df67-202f-ac23-c45c-fcb5172a70a3@pengutronix.de>
On Fri, Feb 26, 2021 at 01:22:59PM +0100, Marc Kleine-Budde wrote:
> The problem is that netif_receive_skb(skb) is called from a threaded interrupt
> handler, but you should call it from NAPI.
Ah, I was sure it was in fact called from NAPI, but that's only if
is_peripheral is false. It should be as simple as getting rid of this
switch, then, no?
https://elixir.bootlin.com/linux/latest/source/drivers/net/can/m_can/m_can.c#L966
--
Regards,
Torin Cooper-Bennun
Software Engineer | maxiluxsystems.com
next prev parent reply other threads:[~2021-02-26 12:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <602651f9.1c69fb81.302a5.647d@mx.google.com>
[not found] ` <20210215144509.rhds7oybzat6u27w@hardanger.blackshift.org>
[not found] ` <CAALJrqgrmzGHZX+iiMYwMkVMpxtf_3fWYkVA-iMdPOxpGzrCRQ@mail.gmail.com>
2021-02-15 17:44 ` can, tcan4x5x: look to merge rpi support into rpi kernel tree Marc Kleine-Budde
2021-02-16 9:06 ` Torin Cooper-Bennun
2021-02-16 9:13 ` Marc Kleine-Budde
2021-02-16 9:44 ` Torin Cooper-Bennun
2021-02-16 10:28 ` Marc Kleine-Budde
[not found] ` <CAALJrqiVdmLQr7q2ijbWq70RD6PTD8PtVX_zmLW9=uNdc57WqA@mail.gmail.com>
2021-02-16 11:19 ` Marc Kleine-Budde
2021-02-16 11:38 ` Torin Cooper-Bennun
2021-02-16 12:32 ` Marc Kleine-Budde
2021-02-26 12:27 ` Torin Cooper-Bennun
2021-02-26 12:28 ` Marc Kleine-Budde
2021-02-26 12:18 ` Torin Cooper-Bennun
2021-02-26 12:22 ` Marc Kleine-Budde
2021-02-26 12:31 ` Torin Cooper-Bennun [this message]
2021-02-26 12:40 ` Marc Kleine-Budde
2021-02-26 13:26 ` Torin Cooper-Bennun
2021-02-26 13:39 ` Marc Kleine-Budde
2021-02-26 13:45 ` Torin Cooper-Bennun
2021-02-26 14:00 ` Marc Kleine-Budde
2021-02-26 15:26 ` Torin Cooper-Bennun
2021-02-26 16:01 ` Marc Kleine-Budde
2021-02-26 16:14 ` Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226123144.cwhjberqeyjctc6w@bigthink \
--to=torin@maxiluxsystems.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.