On 26.02.2021 13:26:20, Torin Cooper-Bennun wrote: > On Fri, Feb 26, 2021 at 01:40:35PM +0100, Marc Kleine-Budde wrote: > > I think you cannot do (synchronous) SPI from NAPI (which is SoftIRQ context). > > I see. I now understand why you recommend using mcp251xfd as a template > for m_can. > > Am I correct in saying that rx-offload requires RX timestamps to be > available? Proper timestamps for RX and TX would be best, but you can use can_rx_offload_queue_tail() if you don't have any timestamps. > They can be enabled in M_CAN, but the v3.3 manual states that > the internal timestamp generation (apparently only option for tcan4x5x) > cannot be used for CAN-FD. Can you give me a reference to this? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |