From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08757C433DB for ; Fri, 26 Feb 2021 18:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C7D64F1B for ; Fri, 26 Feb 2021 18:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbhBZSJ6 (ORCPT ); Fri, 26 Feb 2021 13:09:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhBZSJy (ORCPT ); Fri, 26 Feb 2021 13:09:54 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15B9C061574 for ; Fri, 26 Feb 2021 10:09:13 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id s8so12108058edd.5 for ; Fri, 26 Feb 2021 10:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Prd3+/CUaZYUUbwRde0gLchKlI288B4PXVq50MaG0rA=; b=rpd+0jSiUKFH0ymdD80JfGmONXrdncxZqZ/UJB/Wl/zUFRCtkjSYeYTcPnhgcLzpQp SvooE+fiL8HS81dQ2+aiJDLHCRgdESGFkjClpLdcYY9q4hgi4PYELPQU+xbopwZWlO9T 0q0bhIXfaIlxd3aCiUB1WwTjJ7OQWA2YiWVSd2rpAEwinA0DvkNEvtvviboQMgmEj7Ui e3ZtAd0DijbsFWNIto+fggRqpMGfwc98WmZupWX4PswI3f9GoACLEszOGY6/iHAn6wF/ Vdo2k8V5/Et9DbgpVJfvtL8C7WUA3l7ipNqs14Yn9K1Dlr2sdWPOWfKmy4vcc7kwGksD jk1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Prd3+/CUaZYUUbwRde0gLchKlI288B4PXVq50MaG0rA=; b=WhfZp5LloC53S08gml9ACq0xSCSWBeJiHr2jEcscKcI8TFslAiVkMlfxKDEDhQbwY9 b/DAxzHw042/pu5lWorPTA84db8bTo1iczj0/JkGatn11hiagDQ7X23vh6V6dQDxrmxt gYT9sBdZm6RnDULl10YmcpFUh+b9jxf5ROq7qiveLw9PZ0/apwjtb0HFv/B+wALQy3nL 6Cl526MRWL5Uif+NBotIeXjFs6q7l97kHltDU0doaZkuL2MrV8RJJ1LfMfgQVMgpWWoh djhJZAfknSowEkth+tAe3OSeXMG7B/2jxmnc9YDLUxWPuDwdhhE7k9/oJ53VNo3hBuj1 KsXg== X-Gm-Message-State: AOAM531xE6Y+3TXQpjORCzQ+VM51R8HFuQG1jOmZldMv18PLubGGpU77 dmbnIAj/CdrFwkw9pauJwzk= X-Google-Smtp-Source: ABdhPJzVVqmSIHUwRVYo3LPEkk3KBchT8l3aiht+0xWTVmeaikYOHIhwXjuxl8ha5WeipaSe1VWgPQ== X-Received: by 2002:a50:d90a:: with SMTP id t10mr4933481edj.162.1614362952639; Fri, 26 Feb 2021 10:09:12 -0800 (PST) Received: from skbuf ([188.25.217.13]) by smtp.gmail.com with ESMTPSA id e22sm6212957edu.61.2021.02.26.10.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 10:09:12 -0800 (PST) Date: Fri, 26 Feb 2021 20:09:11 +0200 From: Vladimir Oltean To: Tobias Waldekranz Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , George McCollister , Horatiu Vultur , Kurt Kanzenbach Subject: Re: [RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload Message-ID: <20210226180910.mljsg22edc4rwzdq@skbuf> References: <20210221213355.1241450-1-olteanv@gmail.com> <20210221213355.1241450-9-olteanv@gmail.com> <87v9afria3.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v9afria3.fsf@waldekranz.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 25, 2021 at 09:42:28PM +0100, Tobias Waldekranz wrote: > On Sun, Feb 21, 2021 at 23:33, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Add a short summary of the methods that a driver writer must implement > > for offloading a link aggregation group, and what is still missing. > > > > Cc: Tobias Waldekranz > > Signed-off-by: Vladimir Oltean > > --- > > Documentation/networking/dsa/dsa.rst | 32 ++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst > > index 463b48714fe9..0a5b06cf4d45 100644 > > --- a/Documentation/networking/dsa/dsa.rst > > +++ b/Documentation/networking/dsa/dsa.rst > > @@ -698,6 +698,38 @@ Bridge VLAN filtering > > function that the driver has to call for each MAC address known to be behind > > the given port. A switchdev object is used to carry the VID and MDB info. > > > > +Link aggregation > > +---------------- > > + > > +Link aggregation is implemented in the Linux networking stack by the bonding > > +and team drivers, which are modeled as virtual, stackable network interfaces. > > +DSA is capable of offloading a link aggregation group (LAG) to hardware that > > +supports the feature, and supports bridging between physical ports and LAGs, > > +as well as between LAGs. A bonding/team interface which holds multiple physical > > +ports constitutes a logical port, although DSA has no explicit concept of a > > +physical port at the moment. Due to this, events where a LAG joins/leaves a > > s/physical/logical/ right? Yes, brain fart #1. > > +bridge are treated as if all individual physical ports that are members of that > > +LAG join/leave the bridge. Switchdev port attributes (VLAN filtering, STP > > +state, etc) on a LAG are treated similarly: DSA offloads the same switchdev > > +port attribute on all members of the LAG. Switchdev objects on a LAG (FDB, MDB) > > +are not yet supported, since the DSA driver API does not have the concept of a > > +logical port ID. > > Switchdev objects (MDB entries and VLANs) are supported, and will be > added to all members of the LAG just like attributes. Static FDB entries > are not switchdev objects though, and are therefore not supported. And brain fart #2.