All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net 08/13] ice: fix memory allocation call
Date: Fri, 26 Feb 2021 13:19:27 -0800	[thread overview]
Message-ID: <20210226211932.46683-8-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210226211932.46683-1-anthony.l.nguyen@intel.com>

From: Bruce Allan <bruce.w.allan@intel.com>

Fix the order of number of array members and member size parameters in a
*calloc() call.

Fixes: b3c3890489f6 ("ice: avoid unnecessary single-member variable-length structs")
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
index 3d9475e222cd..a20edf1538a0 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -717,8 +717,8 @@ static enum ice_status ice_cfg_fw_log(struct ice_hw *hw, bool enable)
 
 			if (!data) {
 				data = devm_kcalloc(ice_hw_to_dev(hw),
-						    sizeof(*data),
 						    ICE_AQC_FW_LOG_ID_MAX,
+						    sizeof(*data),
 						    GFP_KERNEL);
 				if (!data)
 					return ICE_ERR_NO_MEMORY;
-- 
2.20.1


  parent reply	other threads:[~2021-02-26 21:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 21:19 [Intel-wired-lan] [PATCH net 01/13] ice: Fix allowing VF to request more/less queues via virtchnl Tony Nguyen
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 02/13] ice: Fix VFR issues for AVF drivers that expect ATQLEN cleared Tony Nguyen
2021-04-21 19:18   ` Jankowski, Konrad0
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 03/13] ice: Continue probe on link/PHY errors Tony Nguyen
2021-03-10 21:14   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 04/13] ice: Fix VF true promiscuous mode Tony Nguyen
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 05/13] ice: Increase control queue timeout Tony Nguyen
2021-03-09 23:45   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 06/13] ice: Recognize 860 as iSCSI port in CEE mode Tony Nguyen
2021-03-23 22:41   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 07/13] ice: prevent ice_open and ice_stop during reset Tony Nguyen
2021-03-11 22:50   ` Brelinski, TonyX
2021-02-26 21:19 ` Tony Nguyen [this message]
2021-03-09 23:47   ` [Intel-wired-lan] [PATCH net 08/13] ice: fix memory allocation call Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 09/13] ice: remove DCBNL_DEVRESET bit from PF state Tony Nguyen
2021-03-22 23:58   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 10/13] ice: Fix for dereference of NULL pointer Tony Nguyen
2021-03-09 23:49   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 11/13] ice: Use port number instead of PF ID for WoL Tony Nguyen
2021-03-10 23:06   ` Brelinski, TonyX
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 12/13] ice: handle the VF VSI rebuild failure Tony Nguyen
2021-04-21 19:17   ` Jankowski, Konrad0
2021-02-26 21:19 ` [Intel-wired-lan] [PATCH net 13/13] ice: Cleanup fltr list in case of allocation issues Tony Nguyen
2021-03-09 23:51   ` Brelinski, TonyX
2021-04-19 19:21 ` [Intel-wired-lan] [PATCH net 01/13] ice: Fix allowing VF to request more/less queues via virtchnl Jankowski, Konrad0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226211932.46683-8-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.