From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Date: Sat, 27 Feb 2021 01:38:52 +0100 Subject: [PATCH v2 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable In-Reply-To: <20210215195934.67034-3-luka.kovacic@sartura.hr> References: <20210215195934.67034-1-luka.kovacic@sartura.hr> <20210215195934.67034-3-luka.kovacic@sartura.hr> Message-ID: <20210227003852.fxygitdkzmhwwgpq@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 15 February 2021 20:59:33 Luka Kovacic wrote: > Add the loadaddr U-Boot environment variable, as this is available in > the stock Marvell U-Boot by default on Marvell Armada A37XX platforms. Hello Luka! Why is this change needed? mvebu_armada-37xx.h already defines CONFIG_SYS_LOAD_ADDR macro with its default value 0x06000000. So defining loadaddr variable should not be needed at all. And it is suspicious for me why definition is to the same default value. > Signed-off-by: Luka Kovacic > Cc: Luka Perkov > Cc: Robert Marko > --- > include/configs/mvebu_armada-37xx.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h > index 2ad4325eaf..1041df8d91 100644 > --- a/include/configs/mvebu_armada-37xx.h > +++ b/include/configs/mvebu_armada-37xx.h > @@ -103,6 +103,7 @@ > > /* fdt_addr and kernel_addr are needed for existing distribution boot scripts */ > #define CONFIG_EXTRA_ENV_SETTINGS \ > + "loadaddr=0x6000000\0" \ > "scriptaddr=0x6d00000\0" \ > "pxefile_addr_r=0x6e00000\0" \ > "fdt_addr=0x6f00000\0" \