From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lFy0E-00024F-1Z for mharc-grub-devel@gnu.org; Sat, 27 Feb 2021 06:43:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFy0C-00023z-7P for grub-devel@gnu.org; Sat, 27 Feb 2021 06:43:16 -0500 Received: from dibed.net-space.pl ([84.10.22.86]:44075) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1lFy0A-0006wD-Ho for grub-devel@gnu.org; Sat, 27 Feb 2021 06:43:15 -0500 Received: from router-fw.i.net-space.pl ([192.168.52.1]:60150 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2089135AbhB0LnI (ORCPT ); Sat, 27 Feb 2021 12:43:08 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Sat, 27 Feb 2021 12:43:06 +0100 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org Subject: Re: [PATCH v4 08/13] error: Use %p format code for pointer types Message-ID: <20210227114306.2zalwbxtpjiahvkm@tomti.i.net-space.pl> References: <83e0cdcfa4280ccd65ed420f4512edf290e35aaa.1613700218.git.development@efficientek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83e0cdcfa4280ccd65ed420f4512edf290e35aaa.1613700218.git.development@efficientek.com> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2021 11:43:16 -0000 On Thu, Feb 18, 2021 at 08:47:09PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/loader/i386/pc/linux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/grub-core/loader/i386/pc/linux.c b/grub-core/loader/i386/pc/linux.c > index 814988ab9..0bc5d6807 100644 > --- a/grub-core/loader/i386/pc/linux.c > +++ b/grub-core/loader/i386/pc/linux.c > @@ -230,9 +230,9 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)), > && GRUB_LINUX_ZIMAGE_ADDR + grub_linux16_prot_size > > grub_linux_real_target) > { > - grub_error (GRUB_ERR_BAD_OS, "too big zImage (0x%x > 0x%x), use bzImage instead", > + grub_error (GRUB_ERR_BAD_OS, "too big zImage (%p > %p), use bzImage instead", > (char *) GRUB_LINUX_ZIMAGE_ADDR + grub_linux16_prot_size, > - (grub_size_t) grub_linux_real_target); > + (void *) grub_linux_real_target); I would use PRIxGRUB_SIZE and PRIxGRUB_ADDR respectively. Daniel