From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1lFyLY-00074q-Ab
	for mharc-grub-devel@gnu.org; Sat, 27 Feb 2021 07:05:20 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:60904)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1lFyLW-00074i-Ro
 for grub-devel@gnu.org; Sat, 27 Feb 2021 07:05:18 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:44106)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1lFyLU-0000Gk-N9
 for grub-devel@gnu.org; Sat, 27 Feb 2021 07:05:18 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:60192 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S2088088AbhB0MFM (ORCPT <rfc822;grub-devel@gnu.org>);
 Sat, 27 Feb 2021 13:05:12 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Sat, 27 Feb 2021 13:05:09 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint
 bp->blk_prop in grub_error
Message-ID: <20210227120509.gabuyn5xrqcddovc@tomti.i.net-space.pl>
References: <cover.1613700218.git.development@efficientek.com>
 <041adc37aa48c09c7e63f07406afe9b0b4031f50.1613700218.git.development@efficientek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <041adc37aa48c09c7e63f07406afe9b0b4031f50.1613700218.git.development@efficientek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Feb 2021 12:05:19 -0000

On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote:
> For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to lu, which
> causes the format string check to fail. Use literal and force cast until
> this is debugged.

I think the problem is that currently BF64_DECODE() uses "1ULL". I think it should
look like this

  #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), ((grub_uint64_t) 1) << (len))

instead of

  #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), 1ULL << (len))

Same or similar for other macros there.

I would prefer if you fix macros in include/grub/zfs/spa.h first and
then do proper fix here.

Daniel