From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Sat, 27 Feb 2021 14:05:50 +0100 Subject: [PATCH v2 1/3] cmd: mvebu: Implement the Marvell hw_info command In-Reply-To: <20210215195934.67034-2-luka.kovacic@sartura.hr> References: <20210215195934.67034-1-luka.kovacic@sartura.hr> <20210215195934.67034-2-luka.kovacic@sartura.hr> Message-ID: <20210227140550.07302fb1@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Luka, Tom, I am very against this. there already is `mac` command in cmd/mac.c with following help display and program the system ID and MAC addresses in EEPROM [read|save|id|num|errata|date|ports|port_number] mac read - read EEPROM content into memory data structure mac save - save memory data structure to the EEPROM mac id - program system id per hard coded value mac num string - program system serial number to value string mac errata string - program errata data to value string mac date YYMMDDhhmmss - program date to string value YYMMDDhhmmss mac ports N - program the number of network ports to integer N mac X string - program MAC addr for port X [X=0,1..] to colon separated string" Why introducing new, vendor specific commands, when we have a global API for such a thing? Marek