From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lGTLD-0003Kq-CZ for mharc-grub-devel@gnu.org; Sun, 28 Feb 2021 16:11:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGTLC-0003IN-8E for grub-devel@gnu.org; Sun, 28 Feb 2021 16:11:02 -0500 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:38961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGTL6-0008Kf-I4 for grub-devel@gnu.org; Sun, 28 Feb 2021 16:11:01 -0500 Received: by mail-ot1-x32e.google.com with SMTP id h22so14522641otr.6 for ; Sun, 28 Feb 2021 13:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=4u20UWbdT/hMZS6qnd6E6A6xyLj6EhcQy6jzv5FFijA=; b=fgHnKnOl2lXOOqjGKu7Ry25+IkZErGSiq5c4HOEs2idf7g3NKsd6SqozOqEv3RFquB jBhT26GSjD2bP8gJ/zvQvIAdTsxlvsuAZ6rSrQlqKbDERxpz7GyLtiqAuly9mGW4exAt yGgYRpn6DoRNeQUU+IoiMSLwprimkbv6twndndPeA2k0A3Uv5uA8xaEQXio3jUgH80oI HD3+BLVuWiz3+87k9CgZLE4STeSZmSrKMBxanHB+VrfOGOB0GWBOxqPQvJrySvUP4D7P 0C8QlL4r1JT93LxZoVr6uMSWFSEUPeo/0QI4iuzf14cxwi7kqW6ET+0CbEmp80aHN/Uh nSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=4u20UWbdT/hMZS6qnd6E6A6xyLj6EhcQy6jzv5FFijA=; b=IGQO4aU2HmXm8ON26fWlrQXMZcgN4tCLgYsZn3HNFexWqAcHZFms/ZroG3VftLNK1m TyQPgSgYw8LI8511mjmbUy418jCqOeBjiMcRch3wmXhwto8GvaofjJl3DGUHD5qGsCiW 6eBslGakhDVvJ7XtuGjE3DPEvlf7XU/kugRATAIYIMEtTGd9LQEEJj4u1SS0y4DOTi4D jPdeVakcDMdBYXncuXLCFNMP39GXkx8/VZhS8M5hK+VqzFmTaE4rK5AJ0ogxZOPfX5RO T7j/6DGV/qnfauQdZGx4G4kbPjfnUIv8oozYDUxwQvuiCtwTdUEx84z/PJzKqPP0Nmac Gqqg== X-Gm-Message-State: AOAM531mya+XjBjmLGuuCtgAWLSGsx0TmJ2f5CrWL41pm6jvjYT1VVsR xk5yUtQ6cSTfR+VEJn9GD3KV7y9erld4rw== X-Google-Smtp-Source: ABdhPJwAp1m7ZIPi8Z8mha1rS1YjiBpz6glRLKDUN4AM/PZ6n52KtiSy7/zo8GcwBf9RrE5zEAQdDg== X-Received: by 2002:a9d:4e2:: with SMTP id 89mr10868708otm.140.1614546654284; Sun, 28 Feb 2021 13:10:54 -0800 (PST) Received: from crass-HP-ZBook-15-G2 (47-218-208-29.bcstcmtk03.res.dyn.suddenlink.net. [47.218.208.29]) by smtp.gmail.com with ESMTPSA id v8sm2180872oto.6.2021.02.28.13.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Feb 2021 13:10:54 -0800 (PST) Date: Sun, 28 Feb 2021 15:10:52 -0600 From: Glenn Washburn To: Daniel Kiper Cc: grub-devel@gnu.org Subject: Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error Message-ID: <20210228151052.0b667476@crass-HP-ZBook-15-G2> In-Reply-To: <20210227120509.gabuyn5xrqcddovc@tomti.i.net-space.pl> References: <041adc37aa48c09c7e63f07406afe9b0b4031f50.1613700218.git.development@efficientek.com> <20210227120509.gabuyn5xrqcddovc@tomti.i.net-space.pl> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=development@efficientek.com; helo=mail-ot1-x32e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2021 21:11:02 -0000 On Sat, 27 Feb 2021 13:05:09 +0100 Daniel Kiper wrote: > On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote: > > For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to > > lu, which causes the format string check to fail. Use literal and > > force cast until this is debugged. > > I think the problem is that currently BF64_DECODE() uses "1ULL". I > think it should look like this > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), > ((grub_uint64_t) 1) << (len)) > > instead of > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), 1ULL << > (len)) > > Same or similar for other macros there. > > I would prefer if you fix macros in include/grub/zfs/spa.h first and > then do proper fix here. Yep, completely agree, just hadn't figured out a proper solution. And not being familiar with the code and not doing the zfs functional tests (GitLab CI shared runners do not have zfs kernel support), I'm hesitant to make such intrusive changes. However, your suggestion is the better way to do it and I've confirmed that it work on i386 and x86_64. I'll update the patch in the next patch series. Glenn